Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add backport github action #9835

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

carolinaecalderon
Copy link
Contributor

@carolinaecalderon carolinaecalderon commented Aug 19, 2024

Ticket

CM-446

Description

See https://hpe-aiatscale.atlassian.net/wiki/x/CgBLZQ for more details.
Suppose a developer wants to backport a fix XYZ into release branch release-A. On the pull request for XYZ, add labels backport release-A. Then, after the PR is merged, the github action will trigger :
(1) creating a new backport PR from main into the release branch (in this case release-A)
(2) automatically merging the backport PR

Test Plan

Manual testing done on https://github.com/carolinaecalderon/github-backport

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Aug 19, 2024
Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit f312794
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66c77bf7b6d678000835ad31

@carolinaecalderon carolinaecalderon marked this pull request as ready for review August 19, 2024 15:37
@carolinaecalderon carolinaecalderon requested a review from a team as a code owner August 19, 2024 15:37
Copy link
Member

@mackrorysd mackrorysd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment aside, I think this is looking good. I'm not familiar with Github Actions though, so we ought to have a second set of eyes besides me.

jobs:
backport_and_merge:
runs-on: ubuntu-latest
# Only react to merged PRs for security reasons.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this comment belong a few lines lower?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section was copy/paste'd from https://github.com/tibdex/backport/blob/main/.github/workflows/backport.yml, but I can move the comment around

@carolinaecalderon carolinaecalderon merged commit fb95df8 into main Aug 22, 2024
78 of 91 checks passed
@carolinaecalderon carolinaecalderon deleted the carolinac/rp-tooling-backport branch August 22, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants