Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate Custom Searcher [MD-504] #9829

Merged
merged 7 commits into from
Aug 16, 2024

Conversation

azhou-determined
Copy link
Contributor

@azhou-determined azhou-determined commented Aug 15, 2024

Ticket

Description

Deprecate all custom searchers and methods.

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@azhou-determined azhou-determined requested a review from a team as a code owner August 15, 2024 18:57
@cla-bot cla-bot bot added the cla-signed label Aug 15, 2024
@determined-ci determined-ci requested a review from a team August 15, 2024 18:57
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Aug 15, 2024
Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 20e7da4
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66be8f1717047800089252f4

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.36%. Comparing base (287f3be) to head (20e7da4).
Report is 3 commits behind head on main.

Files Patch % Lines
...rness/determined/searcher/_remote_search_runner.py 50.00% 1 Missing ⚠️
harness/determined/searcher/_search_method.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9829   +/-   ##
=======================================
  Coverage   54.36%   54.36%           
=======================================
  Files        1261     1261           
  Lines      155811   155818    +7     
  Branches     3540     3540           
=======================================
+ Hits        84701    84715   +14     
+ Misses      70972    70965    -7     
  Partials      138      138           
Flag Coverage Δ
backend 45.20% <ø> (+0.01%) ⬆️
harness 72.61% <71.42%> (-0.01%) ⬇️
web 53.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/searcher/_search_runner.py 64.73% <100.00%> (+0.37%) ⬆️
...rness/determined/searcher/_remote_search_runner.py 29.62% <50.00%> (+0.78%) ⬆️
harness/determined/searcher/_search_method.py 73.43% <66.66%> (-0.17%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Contributor

@MikhailKardash MikhailKardash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

**Deprecation Notice**: DeepSpeed Autotune has been deprecated. This feature will be removed in a
future release. Please see :ref:`Search Methods <_search-methods>` for details on supported
preset searchers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. important::

Deprecation Notice: DeepSpeed Autotune is deprecated and will be removed in an upcoming release.
For information on supported search methods, please visit to :ref:search-methods.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azhou-determined i don't think the ref link renders with that extra "_" in front?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it build locally?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think all instances need to be changed

Copy link
Contributor

@tara-hpe tara-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested edits

@determined-ci determined-ci requested a review from a team August 15, 2024 22:48
@azhou-determined azhou-determined merged commit a367cd0 into main Aug 16, 2024
80 of 96 checks passed
@azhou-determined azhou-determined deleted the deprecate-custom-searcher branch August 16, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants