-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate Custom Searcher [MD-504] #9829
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9829 +/- ##
=======================================
Coverage 54.36% 54.36%
=======================================
Files 1261 1261
Lines 155811 155818 +7
Branches 3540 3540
=======================================
+ Hits 84701 84715 +14
+ Misses 70972 70965 -7
Partials 138 138
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
**Deprecation Notice**: DeepSpeed Autotune has been deprecated. This feature will be removed in a | ||
future release. Please see :ref:`Search Methods <_search-methods>` for details on supported | ||
preset searchers. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. important::
Deprecation Notice: DeepSpeed Autotune is deprecated and will be removed in an upcoming release.
For information on supported search methods, please visit to :ref:search-methods
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@azhou-determined i don't think the ref link renders with that extra "_" in front?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it build locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think all instances need to be changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggested edits
Ticket
Description
Deprecate all custom searchers and methods.
Test Plan
Checklist
docs/release-notes/
See Release Note for details.