Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Group and User management (CM-436) #9825

Merged
merged 6 commits into from
Aug 15, 2024
Merged

fix: Group and User management (CM-436) #9825

merged 6 commits into from
Aug 15, 2024

Conversation

johnkim-det
Copy link
Contributor

@johnkim-det johnkim-det commented Aug 15, 2024

Ticket

CM-436

Description

Addresses issues that occur when creating users and deleting/creating groups.

  • Count for groups and users should stay up-to-date
  • Deleting a group should not cause pagination settings to display incorrect empty state for previous page

Test Plan

In EE/With RBAC:

  • Create a user. Count of users should increase without refresh.
  • Create a group. Count of groups should increase without refresh.
  • If creating a group increases the group count enough to add another page, clicking that page number should display the newly created group as expected.
  • If deleting a group decreases the group count enough to remove a page, the page should decrement automatically and display expected results (not an empty state for that page)

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@johnkim-det johnkim-det requested a review from a team as a code owner August 15, 2024 14:38
@cla-bot cla-bot bot added the cla-signed label Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 80.59701% with 13 lines in your changes missing coverage. Please review.

Project coverage is 50.61%. Comparing base (91d0b67) to head (52f4195).
Report is 10 commits behind head on main.

Files Patch % Lines
webui/react/src/pages/Admin/GroupManagement.tsx 75.75% 8 Missing ⚠️
webui/react/src/pages/Admin/UserManagement.tsx 78.57% 3 Missing ⚠️
webui/react/src/pages/Admin/index.tsx 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9825      +/-   ##
==========================================
- Coverage   54.38%   50.61%   -3.77%     
==========================================
  Files        1261      938     -323     
  Lines      155770   126478   -29292     
  Branches     3540     3585      +45     
==========================================
- Hits        84711    64022   -20689     
+ Misses      70921    62324    -8597     
+ Partials      138      132       -6     
Flag Coverage Δ
harness ?
web 54.50% <80.59%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/components/CreateGroupModal.tsx 74.09% <100.00%> (ø)
webui/react/src/components/CreateUserModal.tsx 88.10% <100.00%> (ø)
webui/react/src/components/DeleteGroupModal.tsx 88.23% <100.00%> (ø)
webui/react/src/pages/Admin/index.tsx 95.96% <81.81%> (+95.96%) ⬆️
webui/react/src/pages/Admin/UserManagement.tsx 83.83% <78.57%> (+0.44%) ⬆️
webui/react/src/pages/Admin/GroupManagement.tsx 73.91% <75.75%> (+73.91%) ⬆️

... and 331 files with indirect coverage changes

Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 52f4195
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66be26963577710008f1d4e3
😎 Deploy Preview https://deploy-preview-9825--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johnkim-det johnkim-det merged commit 97353c9 into main Aug 15, 2024
82 of 95 checks passed
@johnkim-det johnkim-det deleted the CM-436 branch August 15, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants