Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: datagrid action pause flake #9802

Merged
merged 3 commits into from
Aug 6, 2024
Merged

test: datagrid action pause flake #9802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c1567f
test: datagrid action pause flake
JComins000 Aug 6, 2024
afd086f
increase timeout
JComins000 Aug 6, 2024
73fb747
increase timeout
JComins000 Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions webui/react/src/e2e/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,14 @@ Use the [VS Code extension](https://marketplace.visualstudio.com/items?itemName=

CI is setup as `test-e2e-react` in `.circleci/config.yml`.

### Manual CI

Run individual tests on ci with `e2e-react` `-g [your test]`.

![trigger pipeline](./docs/images/trigger-pipeline.png)

### Environment

We use `mcr.microsoft.com/playwright` for [docker container](https://playwright.dev/docs/docker).
Update the docker image version along with Playwright version.

Expand Down
Binary file added webui/react/src/e2e/docs/images/trigger-pipeline.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions webui/react/src/e2e/models/common/hew/DataGrid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,7 @@ export class Row<HeadRowType extends HeadRow<Row<HeadRowType>>> extends NamedCom
await this.parentTable.pwLocator.click({
button: 'right',
position: { x: 5, y: this.getY(await this.getIndex()) },
timeout: 10_000,
});
}

Expand Down
6 changes: 4 additions & 2 deletions webui/react/src/e2e/tests/experimentList.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,10 @@ test.describe('Experiment List', () => {
// await test.step('Hyperparameter Search', async () => {});
});

test.skip('DataGrid Action Pause', async () => {
test('DataGrid Action Pause', async () => {
// datagrid can be slow, perhaps related to [ET-677]
projectDetailsPage._page.setDefaultTimeout(10000);

// experiment should initially be paused
const row = projectDetailsPage.f_experimentList.dataGrid.getRowByIndex(0);
await expect.soft((await row.getCellByColumnName('State')).pwLocator).toHaveText('paused');
Expand All @@ -302,7 +305,6 @@ test.describe('Experiment List', () => {
await row.experimentActionDropdown.open();
await row.experimentActionDropdown.resume.pwLocator.click();
await expect.soft((await row.getCellByColumnName('State')).pwLocator).not.toHaveText('paused');
await waitTableStable();

// pause experiment again
await row.experimentActionDropdown.open();
Expand Down
Loading