Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add editor project restricted role and testing [DET-10428] #9796

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

corban-beaird
Copy link
Contributor

@corban-beaird corban-beaird commented Aug 5, 2024

Ticket

DET-10428

Description

Adds pre-canned Editor Project Restricted role, which has the same permissions as an Editor without the ability to create or update projects.

Test Plan

  • Ensure that CI passes

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@corban-beaird corban-beaird requested a review from a team as a code owner August 5, 2024 17:04
@cla-bot cla-bot bot added the cla-signed label Aug 5, 2024
@determined-ci determined-ci requested a review from a team August 5, 2024 17:04
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Aug 5, 2024
Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit e812610
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66b11fb471592e00085baa57
😎 Deploy Preview https://deploy-preview-9796--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@kkunapuli kkunapuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work.

Copy link
Contributor

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@determined-ci determined-ci requested a review from a team August 5, 2024 18:53
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.05%. Comparing base (a4d74af) to head (e812610).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9796   +/-   ##
=======================================
  Coverage   54.05%   54.05%           
=======================================
  Files        1260     1260           
  Lines      155574   155574           
  Branches     3503     3504    +1     
=======================================
+ Hits        84091    84092    +1     
+ Misses      71337    71336    -1     
  Partials      146      146           
Flag Coverage Δ
backend 44.91% <ø> (+<0.01%) ⬆️
harness 72.62% <ø> (ø)
web 53.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@corban-beaird corban-beaird merged commit c3400df into main Aug 6, 2024
68 of 97 checks passed
@corban-beaird corban-beaird deleted the corban/add-editor-project-restricted branch August 6, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants