Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uncomment helm values #9790

Merged
merged 1 commit into from
Aug 2, 2024
Merged

fix: uncomment helm values #9790

merged 1 commit into from
Aug 2, 2024

Conversation

amandavialva01
Copy link
Contributor

@amandavialva01 amandavialva01 commented Aug 2, 2024

Ticket

Description

Avoid nil pointer dereference error during helm install/upgrade by passing in empty resource_manager.defaultNamespace and resource_manager.clusterName

Test Plan

helm install and helm upgrade using this values.yaml

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@amandavialva01 amandavialva01 added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Aug 2, 2024
@cla-bot cla-bot bot added the cla-signed label Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.77%. Comparing base (a034964) to head (d1c3f28).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9790      +/-   ##
==========================================
+ Coverage   54.04%   54.77%   +0.72%     
==========================================
  Files        1260      846     -414     
  Lines      155574    82382   -73192     
  Branches     3504        0    -3504     
==========================================
- Hits        84084    45122   -38962     
+ Misses      71344    37260   -34084     
+ Partials      146        0     -146     
Flag Coverage Δ
backend 44.90% <ø> (+<0.01%) ⬆️
harness 72.62% <ø> (ø)
web ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 415 files with indirect coverage changes

Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit d1c3f28
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66ad5c3297548800085f3fb6

@salonig23 salonig23 self-requested a review August 2, 2024 22:23
Copy link
Contributor

@salonig23 salonig23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amandavialva01 amandavialva01 merged commit 786f258 into main Aug 2, 2024
90 of 104 checks passed
@amandavialva01 amandavialva01 deleted the uncommentHelm branch August 2, 2024 22:31
github-actions bot pushed a commit that referenced this pull request Aug 2, 2024
(cherry picked from commit 786f258)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants