-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't filter single runs in the comparison view #9789
Conversation
This fixes an issue where single search runs were being filtered out of the comparison view in runs view. We were erroneously applying a filter to the search results.
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9789 +/- ##
==========================================
- Coverage 54.05% 49.74% -4.31%
==========================================
Files 1260 938 -322
Lines 155574 126271 -29303
Branches 3504 3506 +2
==========================================
- Hits 84088 62816 -21272
+ Misses 71340 63309 -8031
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
(cherry picked from commit cdbbedd)
Ticket
ET-679
Description
This fixes an issue where single search runs were being filtered out of
the comparison view in runs view. We were erroneously applying a filter
to the search results.
Test Plan
Checklist
docs/release-notes/
See Release Note for details.