-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make groups scope optional to support azure with OIDC #9773
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9773 +/- ##
=======================================
Coverage 54.15% 54.15%
=======================================
Files 1258 1258
Lines 154990 154992 +2
Branches 3500 3501 +1
=======================================
+ Hits 83937 83940 +3
+ Misses 70907 70906 -1
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ticket
CM-407
Description
Add a new config
exclude_groups_scope
in OIDC config, to allow us to connect to OIDC providers like Azure who don't support groups scope.Test Plan
@channolanp Has QA'd these changes and tested the following scenarios:
On Devcluster+Okta:
On Devcluster+Keycloak:
On Devcluster+Azure:
Instructions to set up Azure: https://hpe-aiatscale.atlassian.net/wiki/spaces/HELP/pages/1352466497/OIDC+With+Azure
Checklist
docs/release-notes/
See Release Note for details.