Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use run checkpoint data instead of experiment for run table filter #9767

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

AmanuelAaron
Copy link
Contributor

@AmanuelAaron AmanuelAaron commented Jul 30, 2024

Ticket

ET-656

Description

Fix run filtering bug where filter looked at experiment level checkpoint data instead of run level

Test Plan

Go to the run table and filter by checkpoint count & checkpoint size

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Jul 30, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 4ee37b6
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66a95e0b1dc2f90008ae9429
😎 Deploy Preview https://deploy-preview-9767--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.55%. Comparing base (becd8b6) to head (4ee37b6).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9767      +/-   ##
==========================================
+ Coverage   54.12%   54.55%   +0.43%     
==========================================
  Files        1257      845     -412     
  Lines      154854    82310   -72544     
  Branches     3487        0    -3487     
==========================================
- Hits        83808    44906   -38902     
+ Misses      70900    37404   -33496     
+ Partials      146        0     -146     
Flag Coverage Δ
backend 44.87% <100.00%> (-0.01%) ⬇️
harness 72.04% <ø> (-0.58%) ⬇️
web ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/experiment_filter.go 86.53% <100.00%> (ø)

... and 420 files with indirect coverage changes

@AmanuelAaron AmanuelAaron added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Jul 30, 2024
@AmanuelAaron AmanuelAaron marked this pull request as ready for review July 30, 2024 21:44
@AmanuelAaron AmanuelAaron requested a review from a team as a code owner July 30, 2024 21:44
Copy link
Contributor

@jesse-amano-hpe jesse-amano-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@AmanuelAaron AmanuelAaron merged commit 935799d into main Jul 30, 2024
88 of 101 checks passed
@AmanuelAaron AmanuelAaron deleted the aaron_amanuel/fix-checkpoint-filter branch July 30, 2024 22:29
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants