-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove RM Name from RP descriptions #9758
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9758 +/- ##
==========================================
- Coverage 54.12% 54.11% -0.01%
==========================================
Files 1257 1257
Lines 154854 154854
Branches 3487 3487
==========================================
- Hits 83810 83806 -4
- Misses 70898 70902 +4
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9fef0c1
to
45b7c33
Compare
45b7c33
to
59fde82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid!
(cherry picked from commit becd8b6)
Ticket
Description
Remove the "Resource Manager Name" from the resource pool configuration description since resource managers are now identified and distinguished by their "Cluster Name".
A few more docs changes to replace the terminology "resource manager name" with "resource manager's cluster name"
WebUI Change:
Before
After
Test Plan
CI passes
Checklist
docs/release-notes/
See Release Note for details.