Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumpenv pin numpy to 1.x [MD-470] #9748

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

jgongd
Copy link
Contributor

@jgongd jgongd commented Jul 29, 2024

Ticket

MD-470

Description

The tensorflow in pytorch-tensorflow-cpu/cuda images is not compatible with numpy 2.x. Need to pin numpy to 1.x in these images. Stacktrace can be found in the ticket description.

Related environment PR: determined-ai/environments#273

Test Plan

Submit two experiments and see if they run successfully

  1. Set cpu image to determinedai/pytorch-tensorflow-cpu-dev:5432424 and make sure the experiment runs in a CPU resource pool.
  2. Set cuda image to determinedai/pytorch-tensorflow-cude-dev:5432424 and make sure the experiment runs in a GPU resource pool.

Sample config:

environment:
  image:
    cpu: determinedai/pytorch-tensorflow-cpu-dev:5432424
    cuda: determinedai/pytorch-tensorflow-cuda-dev:5432424
resources:
  resource_pool: default-cpu-pool

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@jgongd jgongd requested review from a team as code owners July 29, 2024 19:17
@jgongd jgongd requested review from kkunapuli and hkang1 July 29, 2024 19:17
@cla-bot cla-bot bot added the cla-signed label Jul 29, 2024
@jgongd jgongd requested a review from loksonarius July 29, 2024 19:17
@determined-ci determined-ci requested a review from a team July 29, 2024 19:17
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Jul 29, 2024
Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 260f0e9
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66a7fb3d3494020008321fce
😎 Deploy Preview https://deploy-preview-9748--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.12%. Comparing base (20ed126) to head (260f0e9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9748      +/-   ##
==========================================
- Coverage   54.12%   54.12%   -0.01%     
==========================================
  Files        1257     1257              
  Lines      154820   154820              
  Branches     3486     3486              
==========================================
- Hits        83804    83795       -9     
- Misses      70870    70879       +9     
  Partials      146      146              
Flag Coverage Δ
backend 44.86% <100.00%> (-0.02%) ⬇️
harness 72.62% <100.00%> (ø)
web 53.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/deploy/gcp/constants.py 100.00% <100.00%> (ø)
master/internal/config/provconfig/aws_config.go 11.20% <ø> (ø)
master/internal/config/provconfig/gcp_config.go 26.76% <100.00%> (ø)

... and 5 files with indirect coverage changes

Copy link
Contributor

@MikhailKardash MikhailKardash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just fix rebase issues

@jgongd jgongd force-pushed the jgong/bumpenv-pin-numpy-to-1.x branch from 8a426e9 to 260f0e9 Compare July 29, 2024 20:27
@determined-ci determined-ci requested a review from a team July 29, 2024 20:27
@jgongd jgongd merged commit 287faf7 into main Jul 30, 2024
83 of 96 checks passed
@jgongd jgongd deleted the jgong/bumpenv-pin-numpy-to-1.x branch July 30, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants