-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bumpenv pin numpy to 1.x [MD-470] #9748
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9748 +/- ##
==========================================
- Coverage 54.12% 54.12% -0.01%
==========================================
Files 1257 1257
Lines 154820 154820
Branches 3486 3486
==========================================
- Hits 83804 83795 -9
- Misses 70870 70879 +9
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just fix rebase issues
8a426e9
to
260f0e9
Compare
Ticket
MD-470
Description
The tensorflow in pytorch-tensorflow-cpu/cuda images is not compatible with numpy 2.x. Need to pin numpy to 1.x in these images. Stacktrace can be found in the ticket description.
Related environment PR: determined-ai/environments#273
Test Plan
Submit two experiments and see if they run successfully
determinedai/pytorch-tensorflow-cpu-dev:5432424
and make sure the experiment runs in a CPU resource pool.determinedai/pytorch-tensorflow-cude-dev:5432424
and make sure the experiment runs in a GPU resource pool.Sample config:
Checklist
docs/release-notes/
See Release Note for details.