fix: load trial data for single run searches in search view #9742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashtonG
added
the
to-cherry-pick
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9742 +/- ##
==========================================
- Coverage 54.12% 49.78% -4.34%
==========================================
Files 1257 934 -323
Lines 154820 125516 -29304
Branches 3486 3486
==========================================
- Hits 83796 62494 -21302
+ Misses 70878 62876 -8002
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gt2345
approved these changes
Jul 26, 2024
| } | ||
| try { | ||
| const trialsResponse = await getExpTrials( | ||
| { id: experiment.id, limit: 2 }, |
There was a problem hiding this comment.
nit: limit 2 seems a bit arbitrary
This loads trial data for single run searches in the search view. this prevents issues with the continue trial where the trial information was missing in the experiment config.
ashtonG
force-pushed
the
bug/ET-647/load-single-trial-search-trial-data
branch
from
7c93753
to
bb15007
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
(cherry picked from commit 875cb48)
dannysauer
added a commit
that referenced
this pull request
Jul 29, 2024
) Co-authored-by: Ashton Galloway <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-647
Description
This loads trial data for single run searches in the search view. this prevents issues with the continue trial where the trial information was missing in the experiment config.
Test Plan
when visiting the search page of a single-run search, both options on the "Continue Run" menu button should open a modal.
Checklist
docs/release-notes/See Release Note for details.