chore: lengthen abbreviation to avoid ambiguity #9733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9733 +/- ##
==========================================
- Coverage 53.44% 53.44% -0.01%
==========================================
Files 1257 1257
Lines 154350 154350
Branches 3298 3298
==========================================
- Hits 82494 82492 -2
- Misses 71706 71708 +2
Partials 150 150
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mackrorysd
force-pushed
the
mackrory-alloc
branch
from
98bb16d to
03129fb
Compare
|
test-react is failing for unrelated reasons - a lot of people are seeing it and it's being worked on in the CI channel. |
carolinaecalderon
added
the
to-cherry-pick
github-actions bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
(cherry picked from commit dc12336)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First time using the
det resourcesCLI and I think the help text could be improved. One quick thing to squeeze in before release is a new command that gets abbreviated as "all", which I think could be confusing as it's not like an option to return all allocations, which is kinda how it reads.Test Plan
Going to install and manually verify
Checklist
docs/release-notes/See Release Note for details.