test: workspace and project api [TESTENG-46] #9731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JComins000
commented
Jul 25, 2024
| @@ -111,8 +111,8 @@ test.describe('User Management', () => { | |||
| await expect(page).toHaveURL(/login/); | |||
| await auth.login({ | |||
| expectedURL: userManagementPage.url, | |||
| password: newAdmin.password, | |||
| username: newAdmin.user?.username, | |||
| password: newAdmin.request.password, | |||
There was a problem hiding this comment.
i wanted to uniformly return "request + response" from all apis.
JComins000
force-pushed
the
jcom/TESTENG-46/workspace-api
branch
from
779694e
to
2ae8610
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9731 +/- ##
==========================================
- Coverage 53.44% 48.93% -4.51%
==========================================
Files 1257 934 -323
Lines 154350 125048 -29302
Branches 3298 3298
==========================================
- Hits 82494 61194 -21300
+ Misses 71706 63704 -8002
Partials 150 150
Flags with carried forward coverage won't be shown. Click here to find out more. |
| }, | ||
| }); | ||
| const newProject = await backgroundApiProject.createProject(workspaceId, request); | ||
| await use({ request, response: newProject }); |
There was a problem hiding this comment.
I like using request and response on all of them. That's a good idea.
djanicekpach
approved these changes
Jul 25, 2024
JComins000
force-pushed
the
jcom/TESTENG-46/workspace-api
branch
from
2ae8610
to
1997749
Compare
JComins000
force-pushed
the
jcom/TESTENG-46/workspace-api
branch
from
1997749
to
459c34f
Compare
this is a known failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
TESTENG-46
Description
adds support for workspace and project created by api as a test fixture
Test Plan
Checklist
docs/release-notes/See Release Note for details.