Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use previously created experiment for pause test #9727

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

emily-roses
Copy link
Contributor

@emily-roses emily-roses commented Jul 25, 2024

Ticket

Description

Instead of creating a new experiment mid-test (which may have been interrupting other tests), use previously created experiment.

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@emily-roses emily-roses requested a review from JComins000 July 25, 2024 15:11
@emily-roses emily-roses requested a review from a team as a code owner July 25, 2024 15:11
@cla-bot cla-bot bot added the cla-signed label Jul 25, 2024
Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 004f86d
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66a951001dcc9e0008e0a075
😎 Deploy Preview https://deploy-preview-9727--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.79%. Comparing base (287faf7) to head (004f86d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9727      +/-   ##
==========================================
- Coverage   54.11%   49.79%   -4.33%     
==========================================
  Files        1257      934     -323     
  Lines      154854   125521   -29333     
  Branches     3485     3486       +1     
==========================================
- Hits        83801    62499   -21302     
+ Misses      70907    62876    -8031     
  Partials      146      146              
Flag Coverage Δ
harness ?
web 53.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 323 files with indirect coverage changes

@emily-roses emily-roses force-pushed the emilybonar/fix-pause-test branch from b21172e to b601adc Compare July 30, 2024 15:55
@emily-roses emily-roses merged commit 2c91098 into main Jul 31, 2024
82 of 95 checks passed
@emily-roses emily-roses deleted the emilybonar/fix-pause-test branch July 31, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants