-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add release notes for workspace slot caps #9706
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9706 +/- ##
==========================================
- Coverage 53.55% 53.36% -0.20%
==========================================
Files 1255 1255
Lines 152867 154035 +1168
Branches 3298 3293 -5
==========================================
+ Hits 81865 82197 +332
- Misses 70852 71688 +836
Partials 150 150
Flags with carried forward coverage won't be shown. Click here to find out more.
|
313203c
to
3f9dfd1
Compare
**New Features** | ||
|
||
- WebUI: A new section called "Namespace Bindings" has been added to the Create Workspace and Edit | ||
Workspace modals. For OSS users, they can input a namespace that they want to bind their |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...modals. OSS users can input a namespace to which they want to bind their workspace...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets merge these and they will get reviewed again when the release notes compilation happens
``default`` namespace instead. For EE users, an additional option of auto-creating a namespace, | ||
and setting the resource quota for that namespace has been added. Users can only set resource | ||
quotas in the WebUI for namespaces created by Determined. The Edit Workspace Modal will display | ||
the enforced resource quota for all namespaces bound to the workspace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WebUI:
- A new section called "Namespace Bindings" has been added to the Create Workspace and Edit Workspace modals. OSS users can input a namespace to which they want to bind their workspace for a given Kubernetes cluster. If no namespace is specified, the workspace will be bound to the namespace specified in the
resource_manager.default_namespace
field in the master configuration YAML. If this field is left blank, then the workspace will be bound to the default Kubernetesdefault
namespace instead. - MLDE users have the additional option of auto-creating a namespace to which the workspace will be bound. If this option is selected, users can also set a resource quota on that auto-created namespace. This will limit the GPU requests available to that workspace from a given Kubernetes cluster. The Edit Workspace Modal will display the enforced resource quota placed on the workspace, which is the lowest GPU limit resource quota that exists within the bound Kubernetes namespace.
- Once the workspace-namespace binding is saved, all workloads created in that workspace will be sent to the bound namespace. If a user decides to change their workspace-namespace binding, future workloads will get sent to the new namespace, but old workloads that are still in progress will remain running.
3f9dfd1
to
fdfdfff
Compare
|
||
- WebUI: | ||
- A new section called "Namespace Bindings" has been added to the Create Workspace and Edit | ||
Workspace modals. OSS users can input a namespace to which they want to bind their |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we do not use "OSS users" in our docs we'll just need to point out when a feature is for the enterprise edition. e.g., WebUI: In the enterprise edition, ...
(i.e., all users are OSS users and some users have the additional distinction of being Enterprise users > they get extra features)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ticket
Description
Test Plan
Checklist
docs/release-notes/
See Release Note for details.