Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add release notes for workspace slot caps #9706

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

salonig23
Copy link
Contributor

@salonig23 salonig23 commented Jul 23, 2024

Ticket

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Jul 23, 2024
@salonig23 salonig23 changed the base branch from main to wksp-namespace-binding July 23, 2024 22:02
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Jul 23, 2024
@determined-ci determined-ci requested a review from a team July 23, 2024 22:02
Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit ad9ee55
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66a15c87f653de000835d19e

@salonig23 salonig23 changed the title Add release notes slot caps chore: add release notes for workspace slot caps Jul 23, 2024
@salonig23 salonig23 marked this pull request as ready for review July 23, 2024 22:02
@salonig23 salonig23 requested a review from tara-hpe July 23, 2024 22:03
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 40.76016% with 904 lines in your changes missing coverage. Please review.

Project coverage is 53.36%. Comparing base (3995b72) to head (3f9dfd1).
Report is 4 commits behind head on main.

Current head 3f9dfd1 differs from pull request most recent head ad9ee55

Please upload reports for the commit ad9ee55 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9706      +/-   ##
==========================================
- Coverage   53.55%   53.36%   -0.20%     
==========================================
  Files        1255     1255              
  Lines      152867   154035    +1168     
  Branches     3298     3293       -5     
==========================================
+ Hits        81865    82197     +332     
- Misses      70852    71688     +836     
  Partials      150      150              
Flag Coverage Δ
backend 44.56% <47.48%> (-0.21%) ⬇️
harness 72.69% <7.35%> (-0.15%) ⬇️
web 51.93% <24.46%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ernal/config/dispatcher_resource_manager_config.go 35.29% <ø> (ø)
master/internal/config/resource_config.go 95.65% <100.00%> (+0.33%) ⬆️
master/internal/config/resource_pool_config.go 95.00% <ø> (ø)
master/internal/rm/kubernetesrm/request_queue.go 82.88% <100.00%> (+0.47%) ⬆️
master/internal/rm/kubernetesrm/spec.go 82.32% <100.00%> (+0.03%) ⬆️
master/internal/rm/rmerrors/errors.go 0.00% <ø> (ø)
webui/react/src/services/api.ts 97.75% <100.00%> (+0.05%) ⬆️
webui/react/src/types.ts 99.69% <100.00%> (+<0.01%) ⬆️
master/internal/rm/kubernetesrm/resource_pool.go 85.15% <95.65%> (+0.09%) ⬆️
master/internal/rm/resource_manager_iface.go 70.00% <0.00%> (-7.78%) ⬇️
... and 22 more

... and 22 files with indirect coverage changes

@salonig23 salonig23 force-pushed the add-release-notes-slot-caps branch from 313203c to 3f9dfd1 Compare July 24, 2024 00:39
**New Features**

- WebUI: A new section called "Namespace Bindings" has been added to the Create Workspace and Edit
Workspace modals. For OSS users, they can input a namespace that they want to bind their
Copy link
Contributor

@amandavialva01 amandavialva01 Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...modals. OSS users can input a namespace to which they want to bind their workspace...

Copy link
Contributor

@tara-hpe tara-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets merge these and they will get reviewed again when the release notes compilation happens

``default`` namespace instead. For EE users, an additional option of auto-creating a namespace,
and setting the resource quota for that namespace has been added. Users can only set resource
quotas in the WebUI for namespaces created by Determined. The Edit Workspace Modal will display
the enforced resource quota for all namespaces bound to the workspace.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebUI:

  • A new section called "Namespace Bindings" has been added to the Create Workspace and Edit Workspace modals. OSS users can input a namespace to which they want to bind their workspace for a given Kubernetes cluster. If no namespace is specified, the workspace will be bound to the namespace specified in the resource_manager.default_namespace field in the master configuration YAML. If this field is left blank, then the workspace will be bound to the default Kubernetes default namespace instead.
  • MLDE users have the additional option of auto-creating a namespace to which the workspace will be bound. If this option is selected, users can also set a resource quota on that auto-created namespace. This will limit the GPU requests available to that workspace from a given Kubernetes cluster. The Edit Workspace Modal will display the enforced resource quota placed on the workspace, which is the lowest GPU limit resource quota that exists within the bound Kubernetes namespace.
  • Once the workspace-namespace binding is saved, all workloads created in that workspace will be sent to the bound namespace. If a user decides to change their workspace-namespace binding, future workloads will get sent to the new namespace, but old workloads that are still in progress will remain running.

@amandavialva01 amandavialva01 changed the base branch from wksp-namespace-binding to main July 24, 2024 16:34
@amandavialva01 amandavialva01 requested review from a team as code owners July 24, 2024 16:34
@salonig23 salonig23 force-pushed the add-release-notes-slot-caps branch from 3f9dfd1 to fdfdfff Compare July 24, 2024 17:03
@determined-ci determined-ci requested a review from a team July 24, 2024 17:03
@salonig23 salonig23 requested review from tara-hpe and removed request for a team July 24, 2024 18:53

- WebUI:
- A new section called "Namespace Bindings" has been added to the Create Workspace and Edit
Workspace modals. OSS users can input a namespace to which they want to bind their
Copy link
Contributor

@tara-hpe tara-hpe Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we do not use "OSS users" in our docs we'll just need to point out when a feature is for the enterprise edition. e.g., WebUI: In the enterprise edition, ...

(i.e., all users are OSS users and some users have the additional distinction of being Enterprise users > they get extra features)

@tara-hpe tara-hpe self-requested a review July 24, 2024 19:17
Copy link
Contributor

@amandavialva01 amandavialva01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@determined-ci determined-ci requested a review from a team July 24, 2024 19:22
Copy link
Contributor

@tara-hpe tara-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salonig23 salonig23 merged commit 24feb35 into main Jul 24, 2024
78 of 91 checks passed
@salonig23 salonig23 deleted the add-release-notes-slot-caps branch July 24, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants