Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move wait statement to shared code #9701

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

JComins000
Copy link
Contributor

@JComins000 JComins000 commented Jul 23, 2024

Ticket

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@JComins000 JComins000 requested a review from a team as a code owner July 23, 2024 18:43
@cla-bot cla-bot bot added the cla-signed label Jul 23, 2024
@JComins000 JComins000 enabled auto-merge (squash) July 23, 2024 18:44
Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 9db49a3
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/669ffc64c571890008316f30
😎 Deploy Preview https://deploy-preview-9701--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JComins000 JComins000 changed the title move wait statement to shared code test: move wait statement to shared code Jul 23, 2024
Copy link
Contributor

@djanicekpach djanicekpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Approved assuming tests pass.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.99%. Comparing base (8776e35) to head (9db49a3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9701      +/-   ##
==========================================
- Coverage   53.55%   48.99%   -4.57%     
==========================================
  Files        1255      932     -323     
  Lines      152711   123481   -29230     
  Branches     3293     3294       +1     
==========================================
- Hits        81787    60495   -21292     
+ Misses      70774    62836    -7938     
  Partials      150      150              
Flag Coverage Δ
harness ?
web 52.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 323 files with indirect coverage changes

@JComins000 JComins000 merged commit 95c636c into main Jul 23, 2024
81 of 94 checks passed
@JComins000 JComins000 deleted the jcom/noissue/quick-deflake branch July 23, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants