Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use postgres 14 in code snippets. #9691

Merged
merged 1 commit into from
Jul 23, 2024
Merged

docs: use postgres 14 in code snippets. #9691

merged 1 commit into from
Jul 23, 2024

Conversation

ioga
Copy link
Contributor

@ioga ioga commented Jul 22, 2024

Description

Update docs to use postgreql 14 instead of 10. Also explicitly state that any version later than 10 is supported.

Test Plan

N/A

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Jul 22, 2024
@determined-ci determined-ci requested a review from a team July 22, 2024 18:43
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Jul 22, 2024
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 6d2cd98
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/669ea860748d71000874ed84
😎 Deploy Preview https://deploy-preview-9691--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.33%. Comparing base (1c7f4b5) to head (6d2cd98).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9691   +/-   ##
=======================================
  Coverage   53.33%   53.33%           
=======================================
  Files        1255     1255           
  Lines      152702   152702           
  Branches     3249     3249           
=======================================
+ Hits        81449    81450    +1     
+ Misses      71101    71100    -1     
  Partials      152      152           
Flag Coverage Δ
backend 44.76% <ø> (+<0.01%) ⬆️
harness 72.84% <ø> (ø)
web 51.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Copy link
Contributor

@tara-hpe tara-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ioga ioga merged commit e000e70 into main Jul 23, 2024
88 of 101 checks passed
@ioga ioga deleted the postgres-docs branch July 23, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants