chore: add configurable posix claims fields to master config [RM-398] #9690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9690 +/- ##
==========================================
- Coverage 53.54% 53.53% -0.01%
==========================================
Files 1256 1256
Lines 152910 152914 +4
Branches 3297 3296 -1
==========================================
- Hits 81873 81870 -3
- Misses 70887 70894 +7
Partials 150 150
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kkunapuli
changed the title
kkunapuli
requested review from
carolinaecalderon and
corban-beaird
and removed request for
carolinaecalderon
| AgentUID int `json:"agent_uid"` | ||
| AgentGID int `json:"agent_gid"` | ||
| AgentUserName string `json:"agent_user_name"` | ||
| AgentGroupName string `json:"agent_group_name"` |
There was a problem hiding this comment.
nit: Could we instead make these match GroupAttributeName & DisplayNameAttributeName, that way it's clear that these aren't the values for these fields, but instead the name of the attribute that can be passed in. Maybe something along the lines of AgentUIDAttributeName?
There was a problem hiding this comment.
Absolutely! I was wondering about the naming; what is the meaning of AttributeName? Is it kinda like a "key" in a key/value pair?
corban-beaird
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
RM-398
Description
Add the following fields to the master config, for saml and oidc:
For now, these fields are unused. Docs will be updated once the fields have an impact.
Test Plan
Checklist
docs/release-notes/See Release Note for details.