Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove experiments immediately after deleting by filtering out deleting experiments #9688

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

AmanuelAaron
Copy link
Contributor

@AmanuelAaron AmanuelAaron commented Jul 22, 2024

Ticket

ET-86

Description

Experiments/Searches in "deleting" state appear in tables. This causes confusing behaviour where a deleted experiment gets removed then re-appers in the table until it gets deleted.

Test Plan

With Flat Run Flag On:

  1. Go to Searches tab in run table
  2. Select one or multiple searches
  3. Delete them and confirm that the search is removed

With Flat Run Flag Off:

  1. Go to Experiments table
  2. Select one or multiple experiments
  3. Delete them and confirm that the experiment is removed

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Jul 22, 2024
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 2c9f9ca
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/669e6ebfdbf1bd000869bc0f

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.35%. Comparing base (086de84) to head (2c9f9ca).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9688   +/-   ##
=======================================
  Coverage   53.34%   53.35%           
=======================================
  Files        1255     1255           
  Lines      152702   152703    +1     
  Branches     3250     3250           
=======================================
+ Hits        81455    81468   +13     
+ Misses      71095    71083   -12     
  Partials      152      152           
Flag Coverage Δ
backend 44.79% <100.00%> (+0.02%) ⬆️
harness 72.84% <ø> (ø)
web 51.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/api_experiment.go 56.76% <100.00%> (+0.02%) ⬆️

... and 8 files with indirect coverage changes

@AmanuelAaron AmanuelAaron marked this pull request as ready for review July 22, 2024 15:13
@AmanuelAaron AmanuelAaron requested a review from a team as a code owner July 22, 2024 15:13
Copy link
Contributor

@jesse-amano-hpe jesse-amano-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thanks for adding the test!

@AmanuelAaron AmanuelAaron merged commit 4a0eb5f into main Jul 23, 2024
82 of 95 checks passed
@AmanuelAaron AmanuelAaron deleted the aaron_amanuel/remove-deleting branch July 23, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants