test: experiment list sort [INFENG-766] #9675
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9675 +/- ##
==========================================
- Coverage 53.32% 48.70% -4.63%
==========================================
Files 1254 931 -323
Lines 152655 123432 -29223
Branches 3244 3243 -1
==========================================
- Hits 81398 60113 -21285
+ Misses 71105 63167 -7938
Partials 152 152
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| // [ET-284] wait before popover close or else it'll flake | ||
| await authedPage.waitForTimeout(1_000); |
There was a problem hiding this comment.
i'm wondering if there's a better way to wait for the page to settle other than adding a timeout. Menu state is debounced to keep the UI responsive for users -- while we're planning a fix to ensure the menu state is committed on close, waiting for a matching request should decrease the amount of time that the test is waiting.
There was a problem hiding this comment.
since the fix is planned, i think i'd rather just wait for the debounce to end for now. it'll be easy to delete the line later once the work gets done. i've got other stuff i need to focus on for now. thanks for approving
There was a problem hiding this comment.
i mean, it would also work for the current waitTableStable stuff as well.
There was a problem hiding this comment.
i just added it to my backlog. thanks for the suggestion
JComins000
force-pushed
the
jcom/noissue/exptracking-sort
branch
from
722437c
to
1019417
Compare
Ticket
INFENG-766
Description
This is the example I gave during my dev presentation. It's good to have this on main because we'll be closer to running correctly against shared environments.
Test Plan
Checklist
docs/release-notes/See Release Note for details.