feat: Add selection label to FlatRuns page (ET-309) #9670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9670 +/- ##
==========================================
- Coverage 53.32% 48.72% -4.61%
==========================================
Files 1254 932 -322
Lines 152657 123488 -29169
Branches 3244 3246 +2
==========================================
- Hits 81403 60166 -21237
+ Misses 71102 63170 -7932
Partials 152 152
Flags with carried forward coverage won't be shown. Click here to find out more.
|
keita-determined
approved these changes
Jul 17, 2024
Comment on lines
238
to
241
| const allSelectedRunIds = useMemo(() => { | ||
| return settings.selection.type === 'ONLY_IN' ? settings.selection.selections : []; | ||
| }, [settings.selection]); | ||
|
|
There was a problem hiding this comment.
this can be replaced with selectedRunIdSet
There was a problem hiding this comment.
its totally optional, but do you think its a good idea to handle the edge case when selectedCount > total?
JComins000
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: ET-309
Description
Add the selection label to the flat runs table.
Also includes fix for bug with "Select all" action
Test Plan
Checklist
docs/release-notes/.See Release Note for details.