-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove singularity agent znode nightly test #9659
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9659 +/- ##
=======================================
Coverage 53.21% 53.21%
=======================================
Files 1254 1254
Lines 152531 152531
Branches 3240 3240
=======================================
+ Hits 81171 81172 +1
+ Misses 71209 71208 -1
Partials 151 151
Flags with carried forward coverage won't be shown. Click here to find out more. |
- dev-ci-cluster-default-user-credentials | ||
requires: | ||
- package-and-push-system-local-ee | ||
agent-use: "-A" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove the agent-use
flag from all occurrences in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks ok to me
Ticket
RM-311
Description
Missed removing one agent nightly test.
Main PR with description- #9516
Test Plan
No test plan needed
Checklist
docs/release-notes/
See Release Note for details.