Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove singularity agent znode nightly test #9659

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

ShreyaLnuHpe
Copy link
Contributor

@ShreyaLnuHpe ShreyaLnuHpe commented Jul 16, 2024

Ticket

RM-311

Description

Missed removing one agent nightly test.
Main PR with description- #9516

Test Plan

No test plan needed

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 918f3d8
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66969f5259bfba0008b71f2e

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.21%. Comparing base (0494cdf) to head (918f3d8).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9659   +/-   ##
=======================================
  Coverage   53.21%   53.21%           
=======================================
  Files        1254     1254           
  Lines      152531   152531           
  Branches     3240     3240           
=======================================
+ Hits        81171    81172    +1     
+ Misses      71209    71208    -1     
  Partials      151      151           
Flag Coverage Δ
backend 44.68% <ø> (+<0.01%) ⬆️
harness 72.76% <ø> (ø)
web 51.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@ShreyaLnuHpe ShreyaLnuHpe changed the title remove singularity agent znode nightly test chore: remove singularity agent znode nightly test Jul 16, 2024
- dev-ci-cluster-default-user-credentials
requires:
- package-and-push-system-local-ee
agent-use: "-A"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove the agent-use flag from all occurrences in this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@NicholasBlaskey NicholasBlaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link
Contributor

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks ok to me

@ShreyaLnuHpe ShreyaLnuHpe merged commit 6528500 into main Jul 16, 2024
113 of 120 checks passed
@ShreyaLnuHpe ShreyaLnuHpe deleted the shreya/ciHealth branch July 16, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants