chore: saas authz changes for rbac #9657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
trentwatt
force-pushed
the
trent/saas-authz
branch
from
eee7b2a to
8441204
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9657 +/- ##
==========================================
- Coverage 53.56% 53.53% -0.03%
==========================================
Files 1255 1256 +1
Lines 152701 152742 +41
Branches 3292 3293 +1
==========================================
- Hits 81788 81778 -10
- Misses 70763 70814 +51
Partials 150 150
Flags with carried forward coverage won't be shown. Click here to find out more.
|
trentwatt
force-pushed
the
trent/saas-authz
branch
from
3334702 to
9b438d1
Compare
trentwatt
commented
Jul 22, 2024
| @@ -34,7 +34,7 @@ func AddSCIMUser(ctx context.Context, suser *model.SCIMUser) (*model.SCIMUser, e | |||
| userID, err := AddUserTx(ctx, tx, &model.User{ | |||
| Username: suser.Username, | |||
| DisplayName: suser.DisplayName, | |||
| Active: true, | |||
| Active: suser.Active, | |||
trentwatt
commented
Jul 22, 2024
| @@ -187,6 +187,7 @@ func (s *service) PostUser(c echo.Context) (interface{}, error) { | |||
| return nil, errors.WithStack(err) | |||
| } | |||
|
|
|||
| u.Active = true | |||
There was a problem hiding this comment.
this change is to preserve the existing behavior of this code path in light of the following change:
https://github.com/determined-ai/determined/pull/9657/files#r1687035860
trentwatt
commented
Jul 22, 2024
Comment on lines
+560
to
+562
| if a.m.config.InternalConfig.ExternalSessions.Enabled() { | ||
| return nil, errExternalSessions | ||
| } |
There was a problem hiding this comment.
looks like this was missed last time. we have this check on PatchUser but not on PatchUsers
trentwatt
commented
Jul 22, 2024
Comment on lines
-624
to
-626
| if a.m.config.InternalConfig.ExternalSessions.Enabled() { | ||
| return nil, errExternalSessions | ||
| } |
There was a problem hiding this comment.
this check is erroneous, user settings are not a user management feature, they are a part of how the web stores user preferences
trentwatt
force-pushed
the
trent/saas-authz
branch
from
9b438d1 to
d8b88eb
Compare
maxrussell
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://hpe-aiatscale.atlassian.net/browse/DET-10315
Description
Provisions RBAC user with role assignments to their personal group based on the
defaultClusterRolein the token.Also, since it's no longer feasible to update role assignments based on changes from saas, we are allowing for the updating of a user's active status via token.
Test Plan
Checklist
docs/release-notes/See Release Note for details.