fix: SearchDetails Pivot bug [ET-632]

[johnkim-det]

Ticket

ET-632

Description

Refreshing Search Details page displays Pivot options with an incorrect left offset:

Test Plan

Refresh a Search Details page. Should display all Pivot options in correct position, without cutting off or obscuring any of them:

Checklist

• Changes have been manually QA'd
• New features have been approved by the corresponding PM
• User-facing API changes have the "User-facing API Change" label
• Release notes have been added as a separate file under docs/release-notes/
  See Release Note for details.
• Licenses have been included for new code which was copied and/or modified from any external code

[netlify]

✅ Deploy Preview for determined-ui ready!

Name	Link
🔨 Latest commit	087a93a
🔍 Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/66958692c40c770008393b8d
😎 Deploy Preview	https://deploy-preview-9656--determined-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[keita-determined]

\o/

[keita-determined]

the unit test failed

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes missing coverage. Please review.

Project coverage is 48.44%. Comparing base (0494cdf) to head (087a93a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9656      +/-   ##
==========================================
- Coverage   53.21%   48.44%   -4.78%     
==========================================
  Files        1254      931     -323     
  Lines      152531   123395   -29136     
  Branches     3240     3216      -24     
==========================================
- Hits        81171    59777   -21394     
+ Misses      71209    63466    -7743     
- Partials      151      152       +1     

Flag	Coverage Δ
harness	?
web	51.16% <0.00%> (-0.27%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
webui/react/src/pages/SearchDetails.tsx	0.00% <0.00%> (-76.80%)	⬇️

... and 324 files with indirect coverage changes

[keita-determined]

probably its a good idea to write the reason why removing the test file.

[johnkim-det]

fixing this bug revealed that the test cases were only passing in a situation where there was no experiment fetched. When we do have an experiment, tests then need to correctly render FlatRuns, ExperimentCodeViewer, Notes, Page, and ExperimentDetailsHeader, in addition to, of course, Pivot, which is the only thing really being tested by the existing test case. There are errors for several of those components, which could be addressed in SearchDetails.test.tsx... But it feels like making sure all of that works together is best handled by an e2e test? And also that unit tests for the components used by the pages would be more appropriate than trying to "unit test" the entire page.

created ET-634 and ET-635 to capture additional unit testing.