Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support image pull secrets in genai #9653

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

tayritenour
Copy link
Contributor

@tayritenour tayritenour commented Jul 12, 2024

Ticket

GAS-1112 (part of GAS-1111)

Description

Populate image pull secrets on k8s deployments correctly. Passing it in the environment variables allows the genai backend to create experiments with the secret bound.

Test Plan

Does not need to be tested in release party.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.99%. Comparing base (a498008) to head (eb89802).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9653   +/-   ##
=======================================
  Coverage   52.99%   52.99%           
=======================================
  Files        1255     1255           
  Lines      152884   152884           
  Branches     3233     3234    +1     
=======================================
+ Hits        81019    81026    +7     
+ Misses      71714    71707    -7     
  Partials      151      151           
Flag Coverage Δ
backend 44.19% <ø> (+0.01%) ⬆️
harness 72.77% <ø> (ø)
web 51.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@tayritenour tayritenour requested a review from ioga July 12, 2024 22:31
Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit eb89802
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6691aea1182d770008abdda1
😎 Deploy Preview https://deploy-preview-9653--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tayritenour tayritenour merged commit e630bfb into main Jul 12, 2024
90 of 104 checks passed
@tayritenour tayritenour deleted the support_genai_image_pull_secrets branch July 12, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants