fix: ensure historic usage charts assume the correct timezone (DET-10407) #9650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9650 +/- ##
==========================================
- Coverage 57.01% 52.99% -4.02%
==========================================
Files 761 1255 +494
Lines 103084 152888 +49804
Branches 3233 3234 +1
==========================================
+ Hits 58771 81027 +22256
- Misses 44162 71710 +27548
Partials 151 151
Flags with carried forward coverage won't be shown. Click here to find out more.
|
keita-determined
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
added few comments, otherwise lgtm
@@@@@@ @@@@@@
@@@@@@@@@@ @@@@@@@@@@@@@@@@@@@@@@@@
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@@@@@@@@@@@%#***#%%@@@@@@%#****#@@@@@@@@@@@
@@@@@@@@*:::::::::::::::::::::::::-@@@@@@@@
@@@@@@@-:::. .::::::::::::::. .:::*@@@@@@
@@@@@=:::.:***.::::::::::::.+**-.:::%@@@@@
@@@@@-:::.=***-.::::::::::.:****.:::#@@@@
@@@@@@ @@@@@@@@@@+:::.:***:.:::::::::::.+**=.:::%@@@@ @@@@ @@@@@
@@@@@@@@ @@@@::::.. ..:::::+=::::::. .::::@@@@ @@@@@@@@
@@ @@@@-::::::::::::::::::::::::::-@@@@ @@
@@@@#::::::::::+=::::::::::=@@@@
@@+ @@@@@@@@%#*******#%@@@@@@@
@@%%@ @@@@@@@@@@@@@@
:: @@*% @@@@@@@@@@@@@@@@
@@#@@@ @@@@@@@@@@@@@@@@@@
@@@@@@@@@@@@@@@@@@@@@@@@@@@
@@@@@@@@@@@@@@@@@@@@ @@@@
@@@@@@@@@@@@@ @@@@
@@@@@@@@@@@@@ @@@@
@@@@@@@@%@@@@ @@@@
:::::%@@%-@@@++@@@-@@@#:::::
:::::::*@@@#-+@@@--@@@+-%@@@+:::::::
::::::::----:*@@+::::+@@*:----:::::::::
:::::::::::-------::::-------:::::::::::
:::::::::::---:---::---:----::::::::::
:::::::::---:--------:---:::::::::
::::---:--------:----::::
webui/react/src/pages/Cluster/ClusterHistoricalUsageFilters.tsx
Outdated
Show resolved
Hide resolved
keita-determined
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
....................................................:+#####+-.......................................
...................................................=#%*=-=*#%+......................................
...................................................*%%. ...=%#=.....................................
...................................................+%%. ....+%#-....................................
...................................................+%%: ....#%+:...................................
...................................................+%%: ....=%#-...................................
..................................................:*%%. ....:#%=...................................
.................................................:+%%: .....-%%=...................................
.................................................+%#: ......+%*:...................................
...............................................:*%#:. .......#%+:...................................
..............................................:#%*: .......:%%=....................................
.............................................-#%*: .......+%#******+**+**+**+=-...................
............................................+#%+. .......******************#%%#-.................
....................:-+++++++++++++++++++=-#%#- .........:#%*:................
............. .....=%%%%%%%%%%%%%%%%%%%%%%%%+.. .........+%*-................
...................+%#++++++++++++++++*#%#-. ..........=%%+.................
...................*%#++++++++++++++++*#+... .........:+#%%+..................
...................+%#++++++++++++++++*#+... .........-#%#..................
...................+%#++++++++++++++++*#+... ..........#%*..................
...................*%#++++++++++++++++*#+... .........-*%#:..................
...................+%#++++++++++++++++*#+... ........:*%%%-...................
...................*%#++++++++++++++++*#+... .........-#%*...................
...................+%#++++++++++++++++*#+... .........=#%=...................
...................*%#++++++++++++++++*#+... .........:=#%+....................
...................*%#++++++++++++++++*#+... .........:+#%#:....................
...................+%#++++++++++++++++*#+... .........+%%-....................
...................*%#++++++++++++++++*#*=:. ........:*%#:....................
...................+%#++++++++++++++++*#%%%%*-:.................:::::::::=*%%#-.....................
...................*%#*+++++++++++++++*%%+-*##%%%%%%%%%%%%%%%%%%%%%%%%%%%##*=:......................
...................:#%%%%%%%%%%%%%%%%%%%*:..........................................................
tara-det-ai
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
DET-10407
Description
An escalation was reported that the data being presented in the historic usage charts was excluding expected start & end dates of the provided range. This adjusts the terminology in the frontend & query parameters to be reflective of this inclusion.
Additionally, this PR adjust the
Date.parse()call for the X axis on the Historic Usage Charts to ensure that the comparison between times is done based on the local timezone, so that when the information is rendered in the Line Chart all communicated information is visible.Test Plan
Clustertab2024-01-01 12:00amand end with2024-02-01 12:00amChecklist
docs/release-notes/See Release Note for details.