Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add resources allocation-csv to det cli [DFR-519] #9649

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

varlogtim
Copy link
Member

@varlogtim varlogtim commented Jul 12, 2024

PR TITLE (Commit Body)

feat: Add resources allocation-csv to det cli DFR-519

Ticket

DFR-519

Description

Add feature to det cli to allow query of resources allocation-csv endpoint.

Test Plan

run det res all 2024-07-12T00:00:00 2030-01-01T00:00:00 and see that you get output.

Checklist

  • [Y] Changes have been manually QA'd
  • [N] New features have been approved by the corresponding PM
  • [N/A] User-facing API changes have the "User-facing API Change" label
  • [N] Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • [N/A] Licenses have been included for new code which was copied and/or modified from any external code

@varlogtim varlogtim requested a review from a team as a code owner July 12, 2024 15:27
@cla-bot cla-bot bot added the cla-signed label Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.00%. Comparing base (7fab87b) to head (80f8645).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9649      +/-   ##
==========================================
- Coverage   53.01%   53.00%   -0.02%     
==========================================
  Files        1255     1255              
  Lines      152884   152889       +5     
  Branches     3233     3234       +1     
==========================================
- Hits        81057    81032      -25     
- Misses      71676    71706      +30     
  Partials      151      151              
Flag Coverage Δ
backend 44.20% <ø> (-0.05%) ⬇️
harness 72.76% <20.00%> (-0.01%) ⬇️
web 51.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/cli/resources.py 39.13% <20.00%> (-5.32%) ⬇️

... and 6 files with indirect coverage changes

Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 80f8645
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66914b5a28dadb0008c4a41c

Copy link
Contributor

@MikhailKardash MikhailKardash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varlogtim
Copy link
Member Author

@MikhailKardash I decreased the code coverage here, I think. However, there is already a test for this endpoint here:
https://github.com/determined-ai/determined/blob/main/e2e_tests/tests/experiment/test_allocation_csv.py, and this isn't much more than a thin wrapper around the endpoint for convenience sake.

Am I going to break anything if I ignore the code coverage failure?

@varlogtim varlogtim requested a review from hkumar92 July 15, 2024 18:37
@varlogtim varlogtim merged commit 9a8591f into main Jul 15, 2024
87 of 101 checks passed
@varlogtim varlogtim deleted the Add_resources_allocation-csv_to_det_res branch July 15, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants