-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test cases for filter group #9647
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9647 +/- ##
==========================================
- Coverage 52.99% 48.56% -4.44%
==========================================
Files 1255 932 -323
Lines 152884 123742 -29142
Branches 3233 3261 +28
==========================================
- Hits 81019 60091 -20928
+ Misses 71714 63500 -8214
Partials 151 151
Flags with carried forward coverage won't be shown. Click here to find out more.
|
3ffb9a1
to
4d39e51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although it'd be nice to get rid of the assertion in FilterGroup.tsx
|
Ticket
ET-199
Description
Test Plan
Checklist
docs/release-notes/
See Release Note for details.