Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test cases for filter group #9647

Merged
merged 5 commits into from
Jul 15, 2024
Merged

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Jul 12, 2024

Ticket

ET-199

Description

Test Plan

  • CI passes

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Jul 12, 2024
Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 8cc7441
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6691b566e5de6900081671df
😎 Deploy Preview https://deploy-preview-9647--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.56%. Comparing base (a498008) to head (8cc7441).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9647      +/-   ##
==========================================
- Coverage   52.99%   48.56%   -4.44%     
==========================================
  Files        1255      932     -323     
  Lines      152884   123742   -29142     
  Branches     3233     3261      +28     
==========================================
- Hits        81019    60091   -20928     
+ Misses      71714    63500    -8214     
  Partials      151      151              
Flag Coverage Δ
harness ?
web 51.76% <0.00%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/components/FilterForm/components/FilterGroup.tsx 81.01% <0.00%> (+68.34%) ⬆️

... and 324 files with indirect coverage changes

Copy link
Contributor

@EmilyBonar EmilyBonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although it'd be nice to get rid of the assertion in FilterGroup.tsx

@keita-determined
Copy link
Contributor Author

LGTM, although it'd be nice to get rid of the assertion in FilterGroup.tsx

as Conjunction is needed because value?.toString() is a string type. also the change i made in FilterGroup.tsx is to replace 'and' with Conjuction.And.

@keita-determined keita-determined merged commit 4ece949 into main Jul 15, 2024
81 of 94 checks passed
@keita-determined keita-determined deleted the test/filter-group branch July 15, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants