Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hide the docker password in cloudformation stacks #9641

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

tayritenour
Copy link
Contributor

@tayritenour tayritenour commented Jul 11, 2024

Ticket

Description

If you investigate the Cloudformation stacks on AWS, the DockerPass field is in plain text. This hides it by doing the same thing we are doing for DBPassword

Test Plan

Not needed to be tested in release party.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@tayritenour tayritenour requested a review from a team as a code owner July 11, 2024 19:07
@cla-bot cla-bot bot added the cla-signed label Jul 11, 2024
Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 832ba69
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66902d78f30edb00089e4a8f

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.99%. Comparing base (53aa974) to head (832ba69).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9641      +/-   ##
==========================================
- Coverage   52.99%   52.99%   -0.01%     
==========================================
  Files        1255     1255              
  Lines      152884   152884              
  Branches     3234     3234              
==========================================
- Hits        81027    81026       -1     
- Misses      71706    71707       +1     
  Partials      151      151              
Flag Coverage Δ
backend 44.18% <ø> (-0.01%) ⬇️
harness 72.78% <ø> (+0.01%) ⬆️
web 51.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@tayritenour tayritenour enabled auto-merge (squash) July 12, 2024 23:53
@tayritenour tayritenour merged commit 0709cab into main Jul 15, 2024
85 of 98 checks passed
@tayritenour tayritenour deleted the hide_docker_pass_aws_stack branch July 15, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants