Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate model hub #9628

Merged
merged 5 commits into from
Jul 16, 2024
Merged

chore: Deprecate model hub #9628

merged 5 commits into from
Jul 16, 2024

Conversation

MikhailKardash
Copy link
Contributor

@MikhailKardash MikhailKardash commented Jul 10, 2024

Ticket

https://hpe-aiatscale.atlassian.net/browse/MD-32

Docs

#9666

Description

Officially deprecate Model Hub with removal planned in the next release.

Test Plan

None

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@MikhailKardash MikhailKardash requested a review from liamcli July 10, 2024 17:04
@cla-bot cla-bot bot added the cla-signed label Jul 10, 2024
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Jul 10, 2024
@determined-ci determined-ci requested a review from a team July 10, 2024 17:04
Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit cbbd789
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6696de162b1cfc00083a36f9

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.91%. Comparing base (3a8c042) to head (cbbd789).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9628      +/-   ##
==========================================
- Coverage   52.91%   52.91%   -0.01%     
==========================================
  Files        1255     1255              
  Lines      153215   153219       +4     
  Branches     3245     3244       -1     
==========================================
- Hits        81081    81079       -2     
- Misses      71983    71989       +6     
  Partials      151      151              
Flag Coverage Δ
backend 44.00% <ø> (-0.01%) ⬇️
harness 72.76% <75.00%> (+<0.01%) ⬆️
web 51.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
model_hub/model_hub/mmdetection/_trial.py 49.65% <100.00%> (+0.71%) ⬆️
model_hub/model_hub/huggingface/_trial.py 23.07% <50.00%> (+0.60%) ⬆️

... and 3 files with indirect coverage changes

@MikhailKardash MikhailKardash requested review from a team and gt2345 and removed request for a team July 10, 2024 19:04
@determined-ci determined-ci requested a review from a team July 10, 2024 22:00
tara-hpe added a commit that referenced this pull request Jul 10, 2024
tara-hpe added a commit that referenced this pull request Jul 10, 2024
@tara-hpe tara-hpe mentioned this pull request Jul 10, 2024
tara-hpe added a commit that referenced this pull request Jul 16, 2024
Notice of deprecated. #9628
@tara-hpe tara-hpe mentioned this pull request Jul 16, 2024
5 tasks
tara-hpe added a commit that referenced this pull request Jul 16, 2024
Notice of deprecated. #9628
@tara-hpe tara-hpe mentioned this pull request Jul 16, 2024
5 tasks
Copy link
Contributor

@tara-hpe tara-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikhailKardash MikhailKardash merged commit 4b3a100 into main Jul 16, 2024
84 of 96 checks passed
@MikhailKardash MikhailKardash deleted the deprecate_model_hub branch July 16, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants