-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: overflow in hyperparameter modal #9626
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9626 +/- ##
==========================================
- Coverage 52.91% 50.79% -2.13%
==========================================
Files 1255 438 -817
Lines 153215 74057 -79158
Branches 3245 3245
==========================================
- Hits 81081 37616 -43465
+ Misses 71983 36290 -35693
Partials 151 151
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does address the issue, but I noticed something when trying out the netlify preview on my iPhone -- looks like safari/webkit makes the rows have an additional vertical space that looks broken. but this doesn't happen on latest-main on my iPhone. can you take a look?
@johnkim-det good catch. fixed the issue and tested on chrome, firefox, and safari. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ticket
ET-308
Description
Screen.Recording.2024-07-09.at.5.01.41.PM.mov
Test Plan
Checklist
docs/release-notes/
See Release Note for details.