Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overflow in hyperparameter modal #9626

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Jul 10, 2024

Ticket

ET-308

Description

Screen.Recording.2024-07-09.at.5.01.41.PM.mov

Test Plan

  • open hyperaparatmeter search in experiment detail page
  • Check if the vavlue table does not overflow when the page is narrow and in mobile view

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Jul 10, 2024
@keita-determined keita-determined marked this pull request as ready for review July 10, 2024 00:02
@keita-determined keita-determined requested a review from a team as a code owner July 10, 2024 00:02
Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 996f4e7
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/668f0544e2f28500081481c6
😎 Deploy Preview https://deploy-preview-9626--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.79%. Comparing base (3a8c042) to head (996f4e7).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9626      +/-   ##
==========================================
- Coverage   52.91%   50.79%   -2.13%     
==========================================
  Files        1255      438     -817     
  Lines      153215    74057   -79158     
  Branches     3245     3245              
==========================================
- Hits        81081    37616   -43465     
+ Misses      71983    36290   -35693     
  Partials      151      151              
Flag Coverage Δ
harness ?
web 51.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 817 files with indirect coverage changes

Copy link
Contributor

@johnkim-det johnkim-det left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does address the issue, but I noticed something when trying out the netlify preview on my iPhone -- looks like safari/webkit makes the rows have an additional vertical space that looks broken. but this doesn't happen on latest-main on my iPhone. can you take a look?

@keita-determined
Copy link
Contributor Author

keita-determined commented Jul 10, 2024

this does address the issue, but I noticed something when trying out the netlify preview on my iPhone -- looks like safari/webkit makes the rows have an additional vertical space that looks broken. but this doesn't happen on latest-main on my iPhone. can you take a look?

@johnkim-det good catch. fixed the issue and tested on chrome, firefox, and safari.
i wish there was a better way to test things on all browsers instead of the manual testing,

@keita-determined keita-determined changed the title fix: hyperparameter overflow fix: overflow in hyperparameter modal Jul 10, 2024
Copy link
Contributor

@johnkim-det johnkim-det left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keita-determined keita-determined merged commit 13aa327 into main Jul 11, 2024
81 of 95 checks passed
@keita-determined keita-determined deleted the fix/hyperparameter-overflow branch July 11, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants