-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allocation csv: gpu_hours -> slot_hours, add resource_pool [DET-10408] #9616
Conversation
…vide resource_pool name
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9616 +/- ##
==========================================
- Coverage 52.88% 52.88% -0.01%
==========================================
Files 1255 1255
Lines 153086 153090 +4
Branches 3230 3230
==========================================
- Hits 80965 80964 -1
- Misses 71970 71975 +5
Partials 151 151
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Deploy Preview for determined-ui canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CE/SE question would be if this could break downstream integrations on that column name but since it's not accurate that's okay? alternative would be to make this a pure addition and avoid removing the "gpu_hours" column in the same release.
We discussed on Slack with @hkumar92 ; I'll add mention of this to release notes but no further mitigation should be needed. |
…experiment.resources.slots
c821118
to
78362f7
Compare
5297392
to
06f0f61
Compare
Waiting on acceptance or response to https://hpe-aiatscale.atlassian.net/browse/DET-10408?focusedCommentId=32936
Ticket
DET-10408
Description
Renames the
gpu_hours
column in the allocation report CSV toslot_hours
as this is a more accurate description. Adds aresource_pool
column to help users identify what slot type(s) these slot-hours apply to.Test Plan
Run any number of experiments >0 on a cluster that has at least one slot configured.
On cluster historical usage tab, make sure the end date is current, and click Download CSV.
Choose to group by Allocations and download the CSV
Observe
slot_hours
andresource_pool
columns are present in the downloadChecklist
docs/release-notes/
See Release Note for details.