Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allocation csv: gpu_hours -> slot_hours, add resource_pool [DET-10408] #9616

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

jesse-amano-hpe
Copy link
Contributor

@jesse-amano-hpe jesse-amano-hpe commented Jul 7, 2024

Waiting on acceptance or response to https://hpe-aiatscale.atlassian.net/browse/DET-10408?focusedCommentId=32936

Ticket

DET-10408

Description

Renames the gpu_hours column in the allocation report CSV to slot_hours as this is a more accurate description. Adds a resource_pool column to help users identify what slot type(s) these slot-hours apply to.

Test Plan

Run any number of experiments >0 on a cluster that has at least one slot configured.
On cluster historical usage tab, make sure the end date is current, and click Download CSV.
image
Choose to group by Allocations and download the CSV
image
Observe slot_hours and resource_pool columns are present in the download
image

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Jul 7, 2024
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.88%. Comparing base (000c679) to head (06f0f61).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9616      +/-   ##
==========================================
- Coverage   52.88%   52.88%   -0.01%     
==========================================
  Files        1255     1255              
  Lines      153086   153090       +4     
  Branches     3230     3230              
==========================================
- Hits        80965    80964       -1     
- Misses      71970    71975       +5     
  Partials      151      151              
Flag Coverage Δ
backend 44.00% <0.00%> (-0.01%) ⬇️
harness 72.76% <ø> (ø)
web 51.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/core.go 6.48% <0.00%> (-0.04%) ⬇️

... and 3 files with indirect coverage changes

Copy link

netlify bot commented Jul 7, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 06f0f61
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/669172ab9825630007fbfdac

Copy link
Contributor

@hamidzr hamidzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CE/SE question would be if this could break downstream integrations on that column name but since it's not accurate that's okay? alternative would be to make this a pure addition and avoid removing the "gpu_hours" column in the same release.

@jesse-amano-hpe jesse-amano-hpe marked this pull request as ready for review July 11, 2024 20:01
@jesse-amano-hpe jesse-amano-hpe requested a review from a team as a code owner July 11, 2024 20:01
@jesse-amano-hpe
Copy link
Contributor Author

CE/SE question would be if this could break downstream integrations on that column name but since it's not accurate that's okay? alternative would be to make this a pure addition and avoid removing the "gpu_hours" column in the same release.

We discussed on Slack with @hkumar92 ; I'll add mention of this to release notes but no further mitigation should be needed.

@determined-ci determined-ci requested a review from a team July 11, 2024 23:16
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Jul 11, 2024
@jesse-amano-hpe jesse-amano-hpe force-pushed the jta/DET-10408/allocation-slot-accuracy branch from c821118 to 78362f7 Compare July 12, 2024 16:49
@determined-ci determined-ci requested a review from a team July 12, 2024 17:47
@jesse-amano-hpe jesse-amano-hpe force-pushed the jta/DET-10408/allocation-slot-accuracy branch from 5297392 to 06f0f61 Compare July 12, 2024 18:15
@jesse-amano-hpe jesse-amano-hpe merged commit e9e4458 into main Jul 12, 2024
83 of 99 checks passed
@jesse-amano-hpe jesse-amano-hpe deleted the jta/DET-10408/allocation-slot-accuracy branch July 12, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants