-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add metadata filtering to SearchRuns #9611
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9611 +/- ##
==========================================
- Coverage 52.91% 52.89% -0.03%
==========================================
Files 1255 1255
Lines 153086 153166 +80
Branches 3230 3229 -1
==========================================
+ Hits 81004 81010 +6
- Misses 71931 72005 +74
Partials 151 151
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit/question: does the location need to be named RUN_METADATA
instead of just METADATA
? Looks like we specify for HYPERPARAMETERS
/RUN_HYPERPARAMETERS
but not for VALIDATIONS
, TRAINING
, or CUSTOM_METRIC
. FWIW it looks like we said METADATA
was fine in grooming.
either way, LocationType changes in web LGTM
Ticket
ET-50
Description
Add the ability to filter base off of arbitrary metadata in SearchRuns endpoint. This should work similarly to how hyperparameters are filtered currently.
Test Plan
Written tests should pass.
Checklist
docs/release-notes/
See Release Note for details.