-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: extend experiment timeout for slurm test #9601
Conversation
✅ Deploy Preview for determined-ui canceled.
|
588934b
to
985f960
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9601 +/- ##
=======================================
Coverage 51.63% 51.64%
=======================================
Files 1255 1255
Lines 152631 152631
Branches 3092 3091 -1
=======================================
+ Hits 78815 78820 +5
+ Misses 73659 73654 -5
Partials 157 157
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let @NicholasBlaskey know what you've decided on about "skipping the collect logs step as we do for test-e2e-managed-devcluster". If you include that in this PR, it could fix the failing CI
Ticket
None
Description
Slurm restart fails on
main
because the underlying trials time out due to image pull. This PR does 2 things:Test Plan
CI passes, specifically:
test-e2e-slurm-restart
Checklist
docs/release-notes/
See Release Note for details.