-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: display runs count in ProjectCard (ET-314) #9600
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9600 +/- ##
==========================================
- Coverage 51.36% 46.64% -4.72%
==========================================
Files 1252 929 -323
Lines 152174 123056 -29118
Branches 3024 3051 +27
==========================================
- Hits 78158 57404 -20754
+ Misses 73858 65496 -8362
+ Partials 158 156 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ashtonG
reviewed
Jul 2, 2024
5 tasks
ashtonG
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-314
Description
ProjectCard should display runs count instead of experiments count when Flat Runs feature flag is on.
Test Plan
With Flat Runs feature flag on
With Flat Runs feature flag on, they should still show experiments.
Checklist
docs/release-notes/
See Release Note for details.