Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stop enabling all in Go linters [RM-346] #9583

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented Jun 27, 2024

Ticket

Description

Switch to a allow list approach on Go linters rather than the deny list approach we took.

Linters list made with golangci-lint linters

Test Plan

CI passes, make sure linters still work by checking bad code gets caught

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@NicholasBlaskey NicholasBlaskey requested a review from a team as a code owner June 27, 2024 17:20
@cla-bot cla-bot bot added the cla-signed label Jun 27, 2024
Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 83165cd
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6682e07c5718cd0008b66b5b

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.35%. Comparing base (664a1c0) to head (83165cd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9583      +/-   ##
==========================================
- Coverage   51.36%   51.35%   -0.02%     
==========================================
  Files        1252     1252              
  Lines      152174   152174              
  Branches     3024     3024              
==========================================
- Hits        78171    78153      -18     
- Misses      73845    73863      +18     
  Partials      158      158              
Flag Coverage Δ
backend 43.97% <ø> (-0.04%) ⬇️
harness 72.80% <ø> (ø)
web 47.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

Copy link
Contributor

@maxrussell maxrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rad, thank you!

@NicholasBlaskey NicholasBlaskey force-pushed the switch_to_allow_list_for_linters branch from 5fe9f04 to 1d7d1b8 Compare July 1, 2024 16:55
@NicholasBlaskey NicholasBlaskey enabled auto-merge (squash) July 1, 2024 16:59
@NicholasBlaskey NicholasBlaskey merged commit ff8c5ae into main Jul 1, 2024
80 of 94 checks passed
@NicholasBlaskey NicholasBlaskey deleted the switch_to_allow_list_for_linters branch July 1, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants