fix: do not modify cached GetAgentsResponse

[kkunapuli]

Ticket

RM-350

Description

The Kubernetes resource manager caches the response to a GetAgents request. Return a deep copy of the cached response to prevent unintentionally modifying the cached response.

Test Plan

Checklist

• Changes have been manually QA'd
• New features have been approved by the corresponding PM
• User-facing API changes have the "User-facing API Change" label
• Release notes have been added as a separate file under docs/release-notes/
  See Release Note for details.
• Licenses have been included for new code which was copied and/or modified from any external code

[netlify]

✅ Deploy Preview for determined-ui ready!

Name	Link
🔨 Latest commit	f004433
🔍 Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/667b2969969c2b0008a44ec1
😎 Deploy Preview	https://deploy-preview-9569--determined-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 49.80%. Comparing base (f1aa1b4) to head (f004433).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9569      +/-   ##
==========================================
- Coverage   49.80%   49.80%   -0.01%     
==========================================
  Files        1247     1247              
  Lines      162241   162249       +8     
  Branches     2888     2887       -1     
==========================================
+ Hits        80803    80806       +3     
- Misses      81266    81271       +5     
  Partials      172      172              

Flag	Coverage Δ
backend	43.89% <70.00%> (-0.01%)	⬇️
harness	63.74% <ø> (ø)
web	46.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
master/internal/rm/kubernetesrm/jobs.go	69.66% <100.00%> (-0.09%)	⬇️
...nal/rm/kubernetesrm/kubernetes_resource_manager.go	30.81% <0.00%> (ø)
master/internal/rm/resource_manager_iface.go	77.77% <75.00%> (-22.23%)	⬇️

... and 5 files with indirect coverage changes

[NicholasBlaskey]

probably is safer to do this copy on jobsService.getAgents in case someone down the line calls this within the jobs service

[kkunapuli]

By that do you mean, copy the response before returning from jobsService.GetAgents() ?

I had that originally, but the function signature didn't return an error. Thinking about it, there's no reason I can't update the jobsService function to return an error. :)