-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add Nvidia drivers version matching test and bump env [MD-413] #9567
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9567 +/- ##
=======================================
Coverage 49.79% 49.80%
=======================================
Files 1247 1247
Lines 162235 162235
Branches 2888 2887 -1
=======================================
+ Hits 80793 80794 +1
+ Misses 81270 81269 -1
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -0,0 +1,37 @@ | |||
import re |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to add this new directory to the CODEOWNERS
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs another bumpenv
after determined-ai/environments#269 is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ticket
Description
In order for fabric manager to work properly, it will need to match the version of the Nvidia driver. Added a test in
e2e_tests/tests/environment/test_nvidia_driver.py
to make sure. The rest of the changes are bump env.The related environments repo PR: determined-ai/environments#269
Test Plan
CI tests pass.
Checklist
docs/release-notes/
See Release Note for details.