Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return workspace name for breadcrumb in Project Details page #9564

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

AmanuelAaron
Copy link
Contributor

@AmanuelAaron AmanuelAaron commented Jun 25, 2024

Ticket

ET-301

Description

Return workspace name in GetProjectsById to fix regression

Test Plan

Select a workspace and select any project. Check to see if workspace name is displayed in the breadcrumb

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Jun 25, 2024
Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit eabcc44
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/667acff8ca203b0008951719

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.20%. Comparing base (f1aa1b4) to head (eabcc44).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9564      +/-   ##
==========================================
+ Coverage   49.80%   52.20%   +2.40%     
==========================================
  Files        1247      753     -494     
  Lines      162241   112452   -49789     
  Branches     2888     2887       -1     
==========================================
- Hits        80803    58711   -22092     
+ Misses      81266    53569   -27697     
  Partials      172      172              
Flag Coverage Δ
backend 34.21% <ø> (-9.69%) ⬇️
harness 63.74% <ø> (ø)
web 46.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 494 files with indirect coverage changes

@AmanuelAaron AmanuelAaron changed the title return workspace name fix: return workspace name for breadcrumb in Project Details page Jun 25, 2024
@AmanuelAaron AmanuelAaron marked this pull request as ready for review June 25, 2024 14:17
@AmanuelAaron AmanuelAaron requested a review from a team as a code owner June 25, 2024 14:17
Copy link
Contributor

@corban-beaird corban-beaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AmanuelAaron AmanuelAaron added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Jun 25, 2024
@AmanuelAaron AmanuelAaron merged commit 2331e5b into main Jun 25, 2024
83 of 99 checks passed
@AmanuelAaron AmanuelAaron deleted the aaron_amanuel/fix-breadcrumb branch June 25, 2024 16:37
keita-determined pushed a commit that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants