-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: return workspace name for breadcrumb in Project Details page #9564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9564 +/- ##
==========================================
+ Coverage 49.80% 52.20% +2.40%
==========================================
Files 1247 753 -494
Lines 162241 112452 -49789
Branches 2888 2887 -1
==========================================
- Hits 80803 58711 -22092
+ Misses 81266 53569 -27697
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. |
AmanuelAaron
changed the title
return workspace name
fix: return workspace name for breadcrumb in Project Details page
Jun 25, 2024
corban-beaird
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
AmanuelAaron
added
the
to-cherry-pick
Pull requests that need to be cherry-picked into the current release
label
Jun 25, 2024
keita-determined
pushed a commit
that referenced
this pull request
Jun 25, 2024
) (cherry picked from commit 2331e5b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-301
Description
Return workspace name in GetProjectsById to fix regression
Test Plan
Select a workspace and select any project. Check to see if workspace name is displayed in the breadcrumb
Checklist
docs/release-notes/
See Release Note for details.