-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add connect modal for notebook and shell tasks [MD-404] #9545
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
im on it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you format and lint files?
bug?:
sometimes, ok
button got frozen. not sure if its from this code or not. i didnt see it in other place though.
Screen.Recording.2024-06-20.at.11.18.03.AM.mov
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9545 +/- ##
==========================================
- Coverage 49.84% 45.20% -4.65%
==========================================
Files 1246 923 -323
Lines 162007 121796 -40211
Branches 2886 2887 +1
==========================================
- Hits 80760 55063 -25697
+ Misses 81076 66561 -14515
- Partials 171 172 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but i have a concern to replace AnyTask
with CommandTask
. can we make sure the input is always CommandTask
or can be AnyTask
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\o/
Ticket
Description
Adds a modal that displays connect options for active shell and notebook tasks.
Test Plan
Checklist
docs/release-notes/
See Release Note for details.