docs: Clarify startuphook #9517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
tara-hpe
force-pushed
the
docs/Clarify-startuphook
branch
from
a45a0f5 to
e869453
Compare
channolanp
reviewed
Jun 13, 2024
| are launched or deep learning operations are performed. The startup hook can be used to customize | ||
| the container environment, install additional dependencies, and download data sets among other shell | ||
| script commands. | ||
| If a ``startup-hook.sh`` file exists in the top level of your model definition directory, it is |
There was a problem hiding this comment.
I think "model definition directory" may be confusing. It is only really applicable to experiments. For shells, notebooks and tensorboards, it would, I think, just be called the context directory. It may be worthwhile saying you need to supply the context directory for the NTS(not C) commands, which should be --context, or -c for each of them. I'm sure you can get it to work with --include as well, but requires a bit more directory management.
tara-hpe
force-pushed
the
docs/Clarify-startuphook
branch
from
e869453 to
929875c
Compare
per customer request
tara-hpe
force-pushed
the
docs/Clarify-startuphook
branch
from
929875c to
db35e03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per customer request
startup-hook.sh does not apply to det cmd. It applies to experiments, notebooks, shells, and TensorBoards, but not commands.
Ticket
Description
Test Plan
Checklist
docs/release-notes/.See Release Note for details.