Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove hyperparameters from projects table #9504

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

AmanuelAaron
Copy link
Contributor

@AmanuelAaron AmanuelAaron commented Jun 12, 2024

Ticket

ET-268

Description

Remove hyperparameter column from projects table and associated code

Test Plan

Tests should pass

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Jun 12, 2024
Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit d3039a9
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6669c09a17be3d0008ad880d

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.95%. Comparing base (86e6b68) to head (d3039a9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9504      +/-   ##
==========================================
- Coverage   48.97%   48.95%   -0.03%     
==========================================
  Files        1238     1238              
  Lines      160512   160446      -66     
  Branches     2784     2784              
==========================================
- Hits        78609    78540      -69     
- Misses      81728    81731       +3     
  Partials      175      175              
Flag Coverage Δ
backend 43.74% <ø> (-0.08%) ⬇️
harness 63.85% <ø> (ø)
web 44.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/db/postgres_experiments.go 57.58% <ø> (-2.87%) ⬇️
master/internal/experiment/bulk_action.go 0.00% <ø> (ø)

... and 4 files with indirect coverage changes

@AmanuelAaron AmanuelAaron changed the title fix remove hyperparameters from projects table fix: remove hyperparameters from projects table Jun 12, 2024
@AmanuelAaron AmanuelAaron marked this pull request as ready for review June 12, 2024 16:42
@AmanuelAaron AmanuelAaron requested a review from a team as a code owner June 12, 2024 16:42
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

would probably call this more of a chore: than a fix:

@AmanuelAaron AmanuelAaron changed the title fix: remove hyperparameters from projects table chore: remove hyperparameters from projects table Jun 12, 2024
@AmanuelAaron AmanuelAaron merged commit 735fb2c into main Jun 17, 2024
90 of 104 checks passed
@AmanuelAaron AmanuelAaron deleted the aaron_amanuel/remove-old-project-hparams branch June 17, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants