Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flat runs comparison view [ET-190] #9477

Merged
merged 11 commits into from
Jun 13, 2024

Conversation

EmilyBonar
Copy link
Contributor

@EmilyBonar EmilyBonar commented Jun 5, 2024

Ticket

ET-190

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@EmilyBonar EmilyBonar added the feature-flagged The changes in this PR are behind a feature flag label Jun 5, 2024
@EmilyBonar EmilyBonar requested a review from a team as a code owner June 5, 2024 20:27
@EmilyBonar EmilyBonar requested a review from gt2345 June 5, 2024 20:27
@cla-bot cla-bot bot added the cla-signed label Jun 5, 2024
@EmilyBonar EmilyBonar marked this pull request as draft June 5, 2024 20:27
@EmilyBonar EmilyBonar removed the request for review from gt2345 June 5, 2024 20:27
Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 8a36660
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/666b16673b29e800080970a1
😎 Deploy Preview https://deploy-preview-9477--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 75.84098% with 237 lines in your changes missing coverage. Please review.

Project coverage is 44.42%. Comparing base (86e6b68) to head (8a36660).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9477      +/-   ##
==========================================
- Coverage   48.97%   44.42%   -4.55%     
==========================================
  Files        1238      916     -322     
  Lines      160512   120973   -39539     
  Branches     2784     2868      +84     
==========================================
- Hits        78609    53742   -24867     
+ Misses      81728    67059   -14669     
+ Partials      175      172       -3     
Flag Coverage Δ
harness ?
web 44.87% <75.84%> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/components/CompareHyperparameters.test.mock.tsx 100.00% <100.00%> (ø)
...ui/react/src/components/CompareHyperparameters.tsx 92.20% <100.00%> (+2.20%) ⬆️
webui/react/src/components/CompareScatterPlots.tsx 91.44% <100.00%> (+0.75%) ⬆️
webui/react/src/components/ComparisonView.tsx 97.77% <100.00%> (+97.77%) ⬆️
webui/react/src/utils/run.ts 100.00% <100.00%> (ø)
webui/react/src/utils/tests/generateTestData.ts 91.08% <100.00%> (+0.51%) ⬆️
...act/src/pages/TrialDetails/TrialDetailsMetrics.tsx 22.15% <50.00%> (+0.30%) ⬆️
webui/react/src/components/CompareHeatMaps.tsx 87.04% <95.65%> (+2.16%) ⬆️
.../react/src/components/ComparisonView.test.mock.tsx 99.31% <99.31%> (ø)
webui/react/src/components/CompareMetrics.tsx 95.34% <94.95%> (+95.34%) ⬆️
... and 4 more

... and 327 files with indirect coverage changes

@EmilyBonar EmilyBonar force-pushed the emilybonar/flat-runs-comparison branch from 7aa3954 to 6fd92ca Compare June 6, 2024 17:51
@EmilyBonar EmilyBonar requested a review from ashtonG June 7, 2024 19:07
@EmilyBonar EmilyBonar marked this pull request as ready for review June 7, 2024 19:07
Copy link
Contributor

@ashtonG ashtonG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good -- had some feedback. Looking into ci failures.

@EmilyBonar EmilyBonar force-pushed the emilybonar/flat-runs-comparison branch from ebc587c to c1697f8 Compare June 12, 2024 14:05
@EmilyBonar EmilyBonar requested a review from ashtonG June 12, 2024 14:05
Copy link
Contributor

@ashtonG ashtonG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EmilyBonar EmilyBonar merged commit 32585ad into main Jun 13, 2024
84 of 97 checks passed
@EmilyBonar EmilyBonar deleted the emilybonar/flat-runs-comparison branch June 13, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed feature-flagged The changes in this PR are behind a feature flag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants