Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use experiment config to determine is_multi_trial in api_runs queries #9475

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

AmanuelAaron
Copy link
Contributor

@AmanuelAaron AmanuelAaron commented Jun 5, 2024

Ticket

ET-296

Description

We want to use the experiment config to determine whether a run is part of a multitrial experiment(search) or not.

Test Plan

Existing tests should pass

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Jun 5, 2024
@AmanuelAaron AmanuelAaron changed the title fix: Use experiment config to determine is_multi_trial in api_runs qu… fix: Use experiment config to determine is_multi_trial in api_runs queries Jun 5, 2024
Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 6e29f94
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6662087a98f1d400080f716b

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.01%. Comparing base (418525e) to head (6e29f94).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9475   +/-   ##
=======================================
  Coverage   49.00%   49.01%           
=======================================
  Files        1234     1234           
  Lines      159699   159699           
  Branches     2781     2780    -1     
=======================================
+ Hits        78261    78275   +14     
+ Misses      81263    81249   -14     
  Partials      175      175           
Flag Coverage Δ
backend 43.82% <100.00%> (+0.03%) ⬆️
harness 64.04% <ø> (-0.01%) ⬇️
web 44.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/api_runs.go 73.55% <100.00%> (ø)

... and 10 files with indirect coverage changes

@AmanuelAaron AmanuelAaron marked this pull request as ready for review June 6, 2024 18:11
@AmanuelAaron AmanuelAaron requested a review from a team as a code owner June 6, 2024 18:11
Copy link
Contributor

@corban-beaird corban-beaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid!

@AmanuelAaron AmanuelAaron merged commit dde6362 into main Jun 10, 2024
84 of 97 checks passed
@AmanuelAaron AmanuelAaron deleted the aaron_amanuel/is-multitrial-fix branch June 10, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants