Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate PPC64/POWER builds #9467

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Conversation

ShreyaLnuHpe
Copy link
Contributor

@ShreyaLnuHpe ShreyaLnuHpe commented Jun 4, 2024

Ticket

RM-294

Description

Deprecate PPC64/POWER builds. Note: This is not just AgentRM specific, but will be deprecated for all RMs

Potential Impact: Built for a single OSS ~3 years ago, haven’t heard of customers using it since. Users can’t use Determined on PPC64 architecture anymore

Packages with our code do not support power pc. Ok to remove in Q3 / 0.33.1.

Current AgentRM deprecation document linked here.
No active customers use PPC64 architecture anymore. Hence it is safe to deprecate. Here are more information about it.

Test Plan

  1. Tried to build an image and upload to circle CI. Images didn't have PPC64 OS arch

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Jun 4, 2024
Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit f4a84db
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/665f465d030a2f00093bd60d

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.00%. Comparing base (a45aa1e) to head (f4a84db).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9467      +/-   ##
==========================================
- Coverage   51.06%   49.00%   -2.07%     
==========================================
  Files         747     1234     +487     
  Lines      111167   159669   +48502     
  Branches     2778     2778              
==========================================
+ Hits        56772    78242   +21470     
- Misses      54220    81252   +27032     
  Partials      175      175              
Flag Coverage Δ
backend 43.78% <ø> (+9.54%) ⬆️
harness 64.04% <ø> (ø)
web 44.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 487 files with indirect coverage changes

@ShreyaLnuHpe ShreyaLnuHpe changed the title remove ppc64 configs Deprecate PPC64/POWER builds Jun 4, 2024
@ShreyaLnuHpe ShreyaLnuHpe changed the title Deprecate PPC64/POWER builds chore: deprecate PPC64/POWER builds Jun 4, 2024
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Jun 4, 2024
@determined-ci determined-ci requested a review from a team June 4, 2024 03:37
@ShreyaLnuHpe ShreyaLnuHpe self-assigned this Jun 4, 2024
@ShreyaLnuHpe ShreyaLnuHpe marked this pull request as ready for review June 4, 2024 04:19
@ShreyaLnuHpe ShreyaLnuHpe requested a review from a team as a code owner June 4, 2024 04:19
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

LGTM

@@ -0,0 +1,5 @@
:orphan:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be a .rst file


**Deprecations**

- Machine Architectures: Deprecate PPC64/POWER builds architecture as part of deprecating underutilized AgentRM features. Users can’t use Determined on PPC64 architecture anymore.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the content and save the file as an *.rst file. Add a sentence about transitioning, e.g.,:

Deprecations

  • Machine Architectures: Due to underutilized AgentRM features, support for PPC64/POWER builds is deprecated. Users should transition to ________ .

Copy link
Contributor

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested changes

@determined-ci determined-ci requested a review from a team June 4, 2024 16:39
@ShreyaLnuHpe ShreyaLnuHpe merged commit 4d8596c into main Jun 4, 2024
99 of 123 checks passed
@ShreyaLnuHpe ShreyaLnuHpe deleted the shreya/deprecatePPC64 branch June 4, 2024 17:28

**Deprecations**

- Machine Architectures: Due to underutilized AgentRM features, support for PPC64/POWER builds is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't have included "Due to underutilized AgentRM features".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The builds don't impact AgentRM specifically, so I wouldn't mention it. I also think it's good to keep the explanation simple.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have corrected the release note as per the discussion in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants