-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate PPC64/POWER builds #9467
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9467 +/- ##
==========================================
- Coverage 51.06% 49.00% -2.07%
==========================================
Files 747 1234 +487
Lines 111167 159669 +48502
Branches 2778 2778
==========================================
+ Hits 56772 78242 +21470
- Misses 54220 81252 +27032
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
LGTM
docs/release-notes/deprecate-ppc64
Outdated
@@ -0,0 +1,5 @@ | |||
:orphan: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be a .rst
file
docs/release-notes/deprecate-ppc64
Outdated
|
||
**Deprecations** | ||
|
||
- Machine Architectures: Deprecate PPC64/POWER builds architecture as part of deprecating underutilized AgentRM features. Users can’t use Determined on PPC64 architecture anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the content and save the file as an *.rst file. Add a sentence about transitioning, e.g.,:
Deprecations
- Machine Architectures: Due to underutilized AgentRM features, support for PPC64/POWER builds is deprecated. Users should transition to ________ .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requested changes
|
||
**Deprecations** | ||
|
||
- Machine Architectures: Due to underutilized AgentRM features, support for PPC64/POWER builds is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't have included "Due to underutilized AgentRM features".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The builds don't impact AgentRM specifically, so I wouldn't mention it. I also think it's good to keep the explanation simple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have corrected the release note as per the discussion in this PR
This reverts commit 4d8596c.
Ticket
RM-294
Description
Deprecate PPC64/POWER builds. Note: This is not just AgentRM specific, but will be deprecated for all RMs
Potential Impact: Built for a single OSS ~3 years ago, haven’t heard of customers using it since. Users can’t use Determined on PPC64 architecture anymore
Packages with our code do not support power pc. Ok to remove in Q3 / 0.33.1.
Current AgentRM deprecation document linked here.
No active customers use PPC64 architecture anymore. Hence it is safe to deprecate. Here are more information about it.
Test Plan
Checklist
docs/release-notes/
.See Release Note for details.