Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert invalid hparam types to json string #9449

Merged
merged 5 commits into from
Jun 5, 2024
Merged

fix: convert invalid hparam types to json string #9449

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c598e69
nested error msg
May 29, 2024
b472d2f
skip invalid types
Jun 4, 2024
9df5e92
to string
Jun 4, 2024
29e0fa6
Merge branch 'main' into aaron_amanuel/run-hparam-error-fix
Jun 5, 2024
152405f
add json error
Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions master/internal/db/postgres_trial.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package db

import (
"context"
"encoding/json"
"fmt"
"math"
"regexp"
Expand Down Expand Up @@ -151,13 +152,20 @@ func BuildRunHParams(runID int, projectID int, hparams map[string]any,
case map[string]any:
nestedHParams, nestedProjHparams, err := BuildRunHParams(runID, projectID, v.(map[string]any), hpName+".")
if err != nil {
return hparamsModel, projHparamsModel, fmt.Errorf("failed to get nested hyperperameters for %s", hpName)
return hparamsModel, projHparamsModel, fmt.Errorf("failed to get nested hyperperameters for %s: %w", hpName, err)
}
hparamsModel = append(hparamsModel, nestedHParams...)
projHparamsModel = append(projHparamsModel, nestedProjHparams...)
continue
default:
return hparamsModel, projHparamsModel, fmt.Errorf("cannot assign hyperparameter %s, received type %T", hpName, val)
valBytes, err := json.Marshal(v)
if err != nil {
return hparamsModel, projHparamsModel,
fmt.Errorf("cannot assign hyperparameter %s, failed to encode type %T: %w", hpName, val, err)
}
valString := string(valBytes)
hp.TextVal = &valString
projHp.Type = MetricTypeString
}
hparamsModel = append(hparamsModel, hp)
projHparamsModel = append(projHparamsModel, projHp)
Expand Down
Loading