fix: Revert to get_checkpoints.sql call to enable NaN & Infinity values in searcher metric #9440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9440 +/- ##
=======================================
Coverage 49.00% 49.00%
=======================================
Files 1234 1234
Lines 159669 159671 +2
Branches 2779 2779
=======================================
+ Hits 78240 78246 +6
+ Misses 81254 81250 -4
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AmanuelAaron
changed the title
AmanuelAaron
changed the title
erikwilson
reviewed
May 30, 2024
| }) | ||
| require.NoError(t, err) | ||
|
|
||
| _, err = api.GetCheckpoint(ctx, &apiv1.GetCheckpointRequest{ |
There was a problem hiding this comment.
small nit: would be good to verify the checkpoint too
salonig23
approved these changes
May 31, 2024
| ckpt, err := internaldb.GetCheckpoint(ctx, req.CheckpointUuid) | ||
| if err != nil { | ||
| return resp, errors.Wrapf(err, "error fetching checkpoint %s from database", req.CheckpointUuid) | ||
| if err := a.m.db.QueryProto( |
There was a problem hiding this comment.
Can we add a comment here saying not to use Bun?
There was a problem hiding this comment.
Added. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-156
Description
Bun unmarshalling of JSON does not support
NaN,Infinity&-InfinityvaluesTest Plan
Unit tests should pass.
Create checkpoints with a
NaN,Infinity&-Infinityvalues, similar to the ones in the added test and callGetCheckpoint. It should return with the correct values in bothsearcher_metric&validation_metrics.Checklist
docs/release-notes/.See Release Note for details.