test: create test users through the API [INFENG-673] #9431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9431 +/- ##
==========================================
- Coverage 48.60% 43.43% -5.17%
==========================================
Files 1233 909 -324
Lines 158973 119050 -39923
Branches 2777 2777
==========================================
- Hits 77272 51713 -25559
+ Misses 81527 67163 -14364
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more. |
JComins000
reviewed
May 28, 2024
JComins000
reviewed
May 28, 2024
JComins000
reviewed
May 28, 2024
JComins000
reviewed
May 28, 2024
djanicekpach
changed the title
djanicekpach
force-pushed
the
djanicek/infeng-673/user-api
branch
from
8cda29c to
34bc190
Compare
djanicekpach
force-pushed
the
djanicek/infeng-673/user-api
branch
from
34bc190 to
47fc944
Compare
JComins000
approved these changes
May 29, 2024
emily-roses
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: create test users through the API INFENG-673
Ticket
https://hpe-aiatscale.atlassian.net/browse/INFENG-673
Description
The playwright test previously created users through the UI. Now they will create and teardown user setup through the API since it is faster and more reliable. There is still a test doing user setup/teardown through the UI so that tests still cover that workflow.
I also spent some time smoothing out flakes. That wound up involving a lot of retries around the 10s refresh for tables but I've gotten bulk actions un-skipped and passing 3+ times in a row in the pipeline which is a good sign.
Test Plan
CI passes several times in a row
Checklist
docs/release-notes/.See Release Note for details.