Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use priority scheduler in e2e tests #9430

Merged
merged 2 commits into from
May 28, 2024

Conversation

kkunapuli
Copy link
Contributor

@kkunapuli kkunapuli commented May 28, 2024

Ticket

RM-315

Description

e2e scheduler tests use the default scheduler. Update tests to use the priority scheduler since it is now default.

Test Plan

None needed.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label May 28, 2024
Copy link

netlify bot commented May 28, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 8fa2214
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/665612bd1e476a0008eb2f0c

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.61%. Comparing base (684c38b) to head (8fa2214).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9430   +/-   ##
=======================================
  Coverage   48.61%   48.61%           
=======================================
  Files        1233     1233           
  Lines      158975   158973    -2     
  Branches     2778     2778           
=======================================
+ Hits        77283    77284    +1     
+ Misses      81518    81515    -3     
  Partials      174      174           
Flag Coverage Δ
backend 42.17% <ø> (ø)
harness 64.02% <ø> (+<0.01%) ⬆️
web 44.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@kkunapuli kkunapuli changed the title use priority for scheduler in e2e tests ci: use priority for scheduler in e2e tests May 28, 2024
@kkunapuli kkunapuli changed the title ci: use priority for scheduler in e2e tests ci: use priority scheduler in e2e tests May 28, 2024
@kkunapuli kkunapuli marked this pull request as ready for review May 28, 2024 18:07
@kkunapuli kkunapuli requested a review from a team as a code owner May 28, 2024 18:07
@kkunapuli kkunapuli requested a review from highvelcty May 28, 2024 18:07
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this passes CI

lgtm

@kkunapuli kkunapuli merged commit 9524dd4 into main May 28, 2024
87 of 101 checks passed
@kkunapuli kkunapuli deleted the kunapuli/test-job-queue-priority branch May 28, 2024 18:18
@kkunapuli kkunapuli restored the kunapuli/test-job-queue-priority branch July 3, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants